C#: Use .NET 10 for building the extractor and running tests. #20898
Merged
michaelnebel merged 14 commits intogithub:mainfrom Dec 11, 2025
Merged
C#: Use .NET 10 for building the extractor and running tests. #20898michaelnebel merged 14 commits intogithub:mainfrom
michaelnebel merged 14 commits intogithub:mainfrom
Conversation
5bbbb72 to
83afda0
Compare
45ce20d to
71ebbfe
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR upgrades the C# extractor and testing infrastructure from .NET 9 to .NET 10, including updates to build tooling, integration tests, and test stubs.
- Updates .NET SDK from 9.0.300/9.0.304 to 10.0.100
- Upgrades Bazel rules_dotnet to 0.21.5 with custom patches
- Migrates target framework from net9.0 to net10.0 across all projects and tests
Reviewed changes
Copilot reviewed 297 out of 301 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/source.json | Updates rules_dotnet source URL and integrity hash to version 0.21.5 |
| misc/bazel/registry/modules/rules_dotnet/0.21.5-codeql.1/MODULE.bazel | Adds new MODULE.bazel configuration for rules_dotnet 0.21.5 with .NET 10.0.100 toolchain |
| misc/bazel/registry/modules/rules_dotnet/0.19.2-codeql.1/MODULE.bazel | Removes obsolete MODULE.bazel for rules_dotnet 0.19.2 |
| misc/bazel/csharp.bzl | Updates TARGET_FRAMEWORK constant from net9.0 to net10.0 |
| csharp/scripts/stubs/helpers.py | Updates stub generation scripts to use .NET 10 SDK and target framework |
| csharp/scripts/gen-assembly-info.py | Updates assembly info to reference .NET 10.0 instead of 9.0 |
| csharp/scripts/create-extractor-pack.sh | Updates RuntimeFrameworkVersion to 10.0.0 for publishing |
| csharp/ql/test/utils/modeleditor/ApplicationModeEndpoints.expected | Updates expected test output from version 9.0.0.0 to 10.0.0.0 |
| csharp/ql/test/resources/stubs/**/*.csproj | Updates target framework from net9.0 to net10.0 in test stub projects |
| csharp/ql/test/library-tests/**/*.expected | Updates expected test outputs to reflect .NET 10 assembly versions |
| csharp/ql/lib/change-notes/2025-12-09-bmn-default-dotnet.md | Adds change note documenting .NET 10 as default for build mode: none |
| csharp/ql/integration-tests/**/*.csproj | Updates target framework from net9.0 to net10.0 in integration test projects |
| csharp/ql/integration-tests/**/global.json | Updates SDK version from 9.0.304 to 10.0.100 in integration tests |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@redsun82 : It looks like we need to re-apply the patch for |
hvitved
approved these changes
Dec 11, 2025
Contributor
hvitved
left a comment
There was a problem hiding this comment.
Looks plausible to me (I don't really know much about Bazel/paket).
71ebbfe to
c69bbce
Compare
hvitved
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we
rules_dotnettil0.21.5with our patch on top (required for running unit tests).10(alpha)paketfor managing NuGet dependencies. In any case - this is not a blocker and we shouldn't disable the warning (for now).