Merged
Conversation
Test Test Test Test Test Test
jketema
force-pushed
the
swift-6.2.3
branch
2 times, most recently
from
fadf31e to
a04b10c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Swift extractor to support Swift 6.2.3. The update includes refreshed prebuilt Swift binaries and resource directories for both macOS and Linux platforms, along with code changes to handle unavailable declarations properly.
- Updated prebuilt Swift toolchain binaries and resource directories for macOS and Linux to Swift 6.2.3
- Added handling to skip unavailable declarations in lookup expressions
- Added type mapping for
BuiltinImplicitActorType(SIL type)
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swift/third_party/resources/swift-prebuilt-macos.tar.zst | Updated macOS prebuilt Swift 6.2.3 toolchain binary with new SHA256 hash and size |
| swift/third_party/resources/swift-prebuilt-linux.tar.zst | Updated Linux prebuilt Swift 6.2.3 toolchain binary with new SHA256 hash and size |
| swift/third_party/resources/resource-dir-macos.zip | Updated macOS resource directory for Swift 6.2.3 with new SHA256 hash and size |
| swift/third_party/resources/resource-dir-linux.zip | Updated Linux resource directory for Swift 6.2.3 with new SHA256 hash and size |
| swift/ql/lib/change-notes/2025-12-18-swift-6.2.3.md | Added change notes documenting the Swift 6.2.3 upgrade as a major analysis change |
| swift/extractor/translators/ExprTranslator.cpp | Added check to skip unavailable declarations when processing lookup expressions |
| swift/extractor/infra/SwiftTagTraits.h | Added type mapping for BuiltinImplicitActorType as a SIL-only type |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
redsun82
approved these changes
Dec 18, 2025
Contributor
redsun82
left a comment
redsun82
left a comment
There was a problem hiding this comment.
I agree with your assessment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant DCA experiment is the "Open" one. Note that there are a number of new extraction errors on SideStore due to module version mismatches, giving a reduction in the number of alerts. Since we already have a number of similar errors on other DCA projects I propose we accept these.
a04b10c is somewhat of a hack to work around some data set check errors visible the integration tests. I wonder if there is some more principled way to deal with unavailable declarations. I did not investigate this further are part of this point update.