Merged
Conversation
Updated README to reflect support for the Rust extractor and added details about Rust generated files.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the README in the misc/codegen directory to document support for the Rust extractor alongside the existing Swift extractor support.
- Added Rust as a supported language in the code generation suite description
- Clearly labeled language-specific generators with [Swift] and [Rust] prefixes
- Added references to Rust-specific generators (
rustgen.pyandrusttestgen.py) - Updated schema documentation to reference both Swift and Rust schema locations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| This directory contains the code generation suite used by the Swift extractor and the QL library. This suite will use | ||
| the abstract class specification of `schema.py` to generate: | ||
| This directory contains the code generation suite used by the Swift and Rust extractors and QL library. This suite will use | ||
| the abstract class specification of a `schema` python module to generate: |
There was a problem hiding this comment.
The word "python" should be capitalized to "Python" as it refers to the programming language name.
Suggested change
| the abstract class specification of a `schema` python module to generate: | |
| the abstract class specification of a `schema` Python module to generate: |
|
|
||
| This directory contains the code generation suite used by the Swift extractor and the QL library. This suite will use | ||
| the abstract class specification of `schema.py` to generate: | ||
| This directory contains the code generation suite used by the Swift and Rust extractors and QL library. This suite will use |
There was a problem hiding this comment.
Add the article "the" before "QL library" for proper grammar.
Suggested change
| This directory contains the code generation suite used by the Swift and Rust extractors and QL library. This suite will use | |
| This directory contains the code generation suite used by the Swift and Rust extractors and the QL library. This suite will use |
hvitved
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated README to reflect support for the Rust extractor and added details about Rust generated files.