Cmake: fix bazel not generating files for the cmake generator#21119
Merged
Cmake: fix bazel not generating files for the cmake generator#21119
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue where Bazel was not generating source files needed by the CMake generator, likely due to recent Bazel updates. The fix adds logic to explicitly detect and build generated C/C++ source files during CMake configuration.
Key changes:
- Adds debug logging to track Bazel command execution
- Implements
cquery-based detection of generated source files with C/C++ extensions - Explicitly builds detected generated source file targets before CMake configuration proceeds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Possibly a recent update of bazel has broken one of the assumptions cmake generation was based on.
This uses a
bazel cqueryto find out generated C/C++ source files that the targets depend on, and insert an explicitbazel buildof them during cmake configuration to ensure those files are available.