Type inference: Disable universal conditions by default#21151
Merged
hvitved merged 1 commit intogithub:mainfrom Jan 22, 2026
Merged
Type inference: Disable universal conditions by default#21151hvitved merged 1 commit intogithub:mainfrom
hvitved merged 1 commit intogithub:mainfrom
Conversation
hvitved
force-pushed
the
rust/disable-universal-conds-by-default
branch
from
1466064 to
ca5c860
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR disables universal conditions by default in the type inference system. Universal conditions allow constraints to be satisfied through universally quantified type parameters without checking their bounds, representing a trade-off in constraint satisfaction.
Changes:
- Changed the default behavior of
useUniversalConditions()fromany()tonone()in the shared type inference module - Removed redundant
useUniversalConditions() { none() }overrides from Rust-specific implementation modules - Updated test expectations to reflect expected loss of type inference for blanket trait implementations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| shared/typeinference/codeql/typeinference/internal/TypeInference.qll | Changed default predicate useUniversalConditions() from any() to none() |
| rust/ql/lib/codeql/rust/internal/typeinference/TypeInference.qll | Removed redundant useUniversalConditions() overrides (4 instances) |
| rust/ql/lib/codeql/rust/internal/typeinference/BlanketImplementation.qll | Removed redundant useUniversalConditions() override |
| rust/ql/test/library-tests/type-inference/type-inference.expected | Updated test expectations to remove 2 type inference results that are no longer derived |
| rust/ql/test/library-tests/type-inference/main.rs | Updated comment to document the expected missing type inference for blanket implementations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
force-pushed
the
rust/disable-universal-conds-by-default
branch
from
ca5c860 to
65ca884
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DCA is good, we appear to have no significant loss in resolved calls.