Rust: Remove mistakenly included inherited associated types#21204
Merged
paldepind merged 1 commit intogithub:mainfrom Jan 22, 2026
Merged
Rust: Remove mistakenly included inherited associated types#21204paldepind merged 1 commit intogithub:mainfrom
paldepind merged 1 commit intogithub:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Rust type inference predicates to avoid mistakenly including inherited associated types in constraint inputs.
Changes:
- Adjust iterator
Itemtype parameter extraction to usegetAssociatedTypeTypeParameter(...)rather than matching on the underlying type alias. - Apply the same fix for both
IteratorandIntoIteratoritem type parameter helpers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hvitved
approved these changes
Jan 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a small mistake introduced in #21165. The tweaked predicates mistakenly included inherited associated types when they should not.