Rust: Implement support for associated types accessed on type parameters#21273
Draft
paldepind wants to merge 2 commits intogithub:mainfrom
Draft
Rust: Implement support for associated types accessed on type parameters#21273paldepind wants to merge 2 commits intogithub:mainfrom
paldepind wants to merge 2 commits intogithub:mainfrom
Conversation
…ameter of an impl block
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| /** Holds if `path` is of the form `<type as trait>::name` */ | ||
| predicate asTraitPath(Path path, TypeRepr typeRepr, Path traitPath, string name) { |
Check warning
Code scanning / CodeQL
Predicates starting with "get" or "as" should return a value Warning
paldepind
force-pushed
the
rust/tp-assoc
branch
from
56445c6 to
77d9d0a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds type inference support for signatures where an associated type is accessed on a type paramere, such as in:
The idea behind the implementation is to turn
T::Contentinto a type parameter. This is explained in the comment forTypeParamAssociatedTypeTypeParameterThe result is that associated types on type parameters are "lowered" into things that we already handle in type inference. For instance, a bound like
T::Output: SomeTraitis just a bound on a type parameter, which we already handle.