Skip to content

JS: Add missing rule to security-and-quality query list#21283

Closed
smowton wants to merge 2 commits intomainfrom
smowton/admin/missing-quality-query
Closed

JS: Add missing rule to security-and-quality query list#21283
smowton wants to merge 2 commits intomainfrom
smowton/admin/missing-quality-query

Conversation

@smowton
Copy link
Contributor

@smowton smowton commented Feb 6, 2026

Has header block

 * @id js/unhandled-error-in-stream-pipeline
 * @name Unhandled error in stream pipeline
 * @description Calling `pipe()` on a stream without error handling will drop errors coming from the input stream
 * @kind problem
 * @problem.severity warning
 * @precision high
 * @tags quality
 *       reliability
 *       error-handling
 *       frameworks/nodejs

... which would get selected by the security-and-quality selectors if we were using them. Any reason to exclude?

Has header block

```
 * @id js/unhandled-error-in-stream-pipeline
 * @name Unhandled error in stream pipeline
 * @description Calling `pipe()` on a stream without error handling will drop errors coming from the input stream
 * @kind problem
 * @problem.severity warning
 * @precision high
 * @tags quality
 *       reliability
 *       error-handling
 *       frameworks/nodejs
```

... which would get selected by the security-and-quality selectors if we were using them. Any reason to exclude?
@smowton smowton requested a review from a team as a code owner February 6, 2026 11:24
Copilot AI review requested due to automatic review settings February 6, 2026 11:24
@github-actions github-actions bot added the JS label Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds the missing js/unhandled-error-in-stream-pipeline query to the JavaScript security-and-quality query suite. The query detects Node.js stream pipelines that lack proper error handling, which can lead to dropped errors and reliability issues. The query has appropriate metadata (quality/reliability tags, high precision, warning severity) that qualifies it for inclusion in the security-and-quality suite.

Changes:

  • Added js/unhandled-error-in-stream-pipeline to the query list in javascript-security-and-quality.qls

@asgerf
Copy link
Contributor

asgerf commented Feb 6, 2026

javascript-security-and-quality.qls.expected needs to be updated otherwise LGTM

@smowton
Copy link
Contributor Author

smowton commented Feb 6, 2026

It appears this actually should not be added to the suite, which is a legacy frozen suite and should not change.

@smowton smowton closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants