JS: Add missing rule to security-and-quality query list#21283
Closed
JS: Add missing rule to security-and-quality query list#21283
Conversation
Has header block ``` * @id js/unhandled-error-in-stream-pipeline * @name Unhandled error in stream pipeline * @description Calling `pipe()` on a stream without error handling will drop errors coming from the input stream * @kind problem * @problem.severity warning * @precision high * @tags quality * reliability * error-handling * frameworks/nodejs ``` ... which would get selected by the security-and-quality selectors if we were using them. Any reason to exclude?
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds the missing js/unhandled-error-in-stream-pipeline query to the JavaScript security-and-quality query suite. The query detects Node.js stream pipelines that lack proper error handling, which can lead to dropped errors and reliability issues. The query has appropriate metadata (quality/reliability tags, high precision, warning severity) that qualifies it for inclusion in the security-and-quality suite.
Changes:
- Added
js/unhandled-error-in-stream-pipelineto the query list injavascript-security-and-quality.qls
Contributor
|
|
Contributor
Author
|
It appears this actually should not be added to the suite, which is a legacy frozen suite and should not change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Has header block
... which would get selected by the security-and-quality selectors if we were using them. Any reason to exclude?