docs: update base branch instructions to use pencil icon (#43423)#43463
docs: update base branch instructions to use pencil icon (#43423)#43463teee32 wants to merge 1 commit intogithub:mainfrom
Conversation
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
There was a problem hiding this comment.
Pull request overview
Updates a pull request documentation page to reflect the current GitHub UI for changing a pull request’s base branch by referencing the pencil icon next to the title (and removing an outdated “Edit” button screenshot).
Changes:
- Replaced the “click Edit” instruction with guidance to use the pencil icon next to the pull request title.
- Removed the outdated screenshot that showed an Edit button.
| 1. Next to the pull request's title, click **Edit**. | ||
|
|
||
|  | ||
| 1. Next to the pull request's title, click the pencil icon to edit the pull request. |
There was a problem hiding this comment.
The UI element here is an icon with tooltip text (currently "Edit title"), so "click the pencil icon to edit the pull request" is a bit vague/inaccurate and may be confusing. Consider using the site’s standard octicon markup (e.g., {% octicon "pencil" ... %}) and wording that matches the UI label/location (e.g., "click the Edit title (pencil) icon next to the pull request title") to make the step clearer and consistent with other docs pages.
| 1. Next to the pull request's title, click the pencil icon to edit the pull request. | |
| 1. Next to the pull request title, click **Edit title** {% octicon "pencil" aria-label="Edit title" %}. |
Fixes #43423\n\nUpdated the steps to reference the pencil icon next to the PR title instead of the outdated Edit button (screenshot removed to avoid keeping stale UI imagery).
Made with Cursor