Skip to content

Allow temporary IDs for all project operations#19573

Draft
Copilot wants to merge 5 commits intomainfrom
copilot/add-temporary-ids-support
Draft

Allow temporary IDs for all project operations#19573
Copilot wants to merge 5 commits intomainfrom
copilot/add-temporary-ids-support

Conversation

Copy link
Contributor

Copilot AI commented Mar 4, 2026

  • Fix TypeScript typecheck error in create_project.cjs (normalizeTemporaryId(temporaryId ?? ""))
  • Verify all create_project_status_update tests pass (16/16)
  • Verify formatting survives make fmt-cjs
  • Build passes

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI and others added 3 commits March 4, 2026 09:33
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
@mnkiefer
Copy link
Contributor

mnkiefer commented Mar 4, 2026

@copilot fix js tests

Co-authored-by: mnkiefer <8320933+mnkiefer@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 4, 2026

@copilot fix js tests

Fixed in 8cb353f. The TypeScript strict null check was failing because normalizeTemporaryId expects string but the JSDoc cast /** @type {string} */ (without parentheses) doesn't survive prettier's TypeScript parser — it gets stripped, leaving the type as string | null. Changed line 463 to normalizeTemporaryId(temporaryId ?? "") which satisfies TypeScript and is formatter-stable. The ?? "" fallback never triggers at runtime since the early return at line 350–356 already handles the null case.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/github/gh-aw/contents/.github%2Fworkflows%2Faudit-workflows.md
    • Triggering command: /opt/hostedtoolcache/node/24.13.1/x64/bin/node /opt/hostedtoolcache/node/24.13.1/x64/bin/node --conditions node --conditions development --experimental-import-meta-resolve --require /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/suppress-warnings.cjs /home/REDACTED/work/gh-aw/gh-aw/actions/setup/js/node_modules/vitest/dist/workers/forks.js m k/gh-aw/node_mod-- git push�� -u origin k/gh-aw/gh-aw/actions/node_modules/.bin/git it git _modules/.bin/git git (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants