[WIP] Remove 'in:comments' flag from history link generation#19608
Merged
[WIP] Remove 'in:comments' flag from history link generation#19608
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the in: field qualifier logic (in:comments / in:body) from history-link search URL generation so the generated GitHub search query relies only on the workflow marker phrase plus existing type filtering.
Changes:
- Removed
in:comments/in:bodyqualifier selection fromgenerate_history_link.cjs. - Updated
generate_history_link.test.cjsto drop assertions/tests that requiredin:qualifiers. - Adjusted the explanatory comment in
add_comment.cjsto match the new history URL behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/setup/js/generate_history_link.cjs | Stops adding in: qualifiers to the history search query (marker phrase only, plus existing repo/type qualifiers). |
| actions/setup/js/generate_history_link.test.cjs | Removes tests/assertions that expected in:comments or in:body to be present in generated URLs/queries. |
| actions/setup/js/add_comment.cjs | Updates comment describing history URL generation to no longer mention in:comments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in:commentsandin:bodyin history link generationin:qualifier logic fromgenerate_history_link.cjsgenerate_history_link.test.cjsto removein:commentsandin:bodyassertionsadd_comment.cjs💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.