-
Notifications
You must be signed in to change notification settings - Fork 276
Enterprise: replace hardcoded github.com with GITHUB_SERVER_URL in safe output JS #19621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
81d09c3
6b7f8f2
77224e1
1ba1b72
09fb33e
2a0754c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -160,7 +160,18 @@ function createHandlers(server, appendSafeOutput, config = {}) { | |
|
|
||
| const githubServer = process.env.GITHUB_SERVER_URL || "https://github.com"; | ||
| const repo = process.env.GITHUB_REPOSITORY || "owner/repo"; | ||
| const url = `${githubServer.replace("github.com", "raw.githubusercontent.com")}/${repo}/${normalizedBranchName}/${targetFileName}`; | ||
| let url; | ||
| try { | ||
| const serverHostname = new URL(githubServer).hostname; | ||
| if (serverHostname === "github.com") { | ||
| url = `https://raw.githubusercontent.com/${repo}/${normalizedBranchName}/${targetFileName}`; | ||
| } else { | ||
| // GitHub Enterprise Server - raw content is served from the same host with /raw/ path | ||
| url = `${githubServer}/${repo}/raw/${normalizedBranchName}/${targetFileName}`; | ||
| } | ||
| } catch { | ||
| url = `${githubServer}/${repo}/raw/${normalizedBranchName}/${targetFileName}`; | ||
| } | ||
|
|
||
| // Create entry for safe outputs | ||
| const entry = { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good approach using |
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
replace(/^https?:\/\//, "")correctly strips the protocol. This pattern is consistent with the enterprise support approach used elsewhere in this PR.