Skip to content

fix: restore thread id in get_review_comments response #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omid-ant wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix: restore thread id in get_review_comments response #2245

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/github/minimal_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package github

import (
"fmt"
"time"

"github.com/google/go-github/v82/github"
Expand Down Expand Up @@ -717,6 +718,7 @@ type MinimalReviewComment struct {

// MinimalReviewThread is the trimmed output type for PR review thread objects.
type MinimalReviewThread struct {
ID string `json:"id"`
IsResolved bool `json:"is_resolved"`
IsOutdated bool `json:"is_outdated"`
IsCollapsed bool `json:"is_collapsed"`
Expand Down Expand Up @@ -853,6 +855,7 @@ func convertToMinimalReviewThread(thread reviewThreadNode) MinimalReviewThread {
}

return MinimalReviewThread{
ID: fmt.Sprintf("%v", thread.ID),
IsResolved: bool(thread.IsResolved),
IsOutdated: bool(thread.IsOutdated),
IsCollapsed: bool(thread.IsCollapsed),
Expand Down