Added all block IDs to world.py#2
Open
tollers wants to merge 2 commits intogmcnew:minecraft113from
tollers:patch-1
Open
Added all block IDs to world.py#2tollers wants to merge 2 commits intogmcnew:minecraft113from tollers:patch-1
tollers wants to merge 2 commits intogmcnew:minecraft113from
tollers:patch-1
Conversation
I have included all blocks and also all items. I presume including items isn't a problem as they shouldn't be requested and the length of the list shouldn't slow things down? If so, perhaps someone else can go through and remove them all. Data was pulled from https://minecraft-ids.grahamedgecombe.com/ and put in to the right format with a string manipulation script I put together.
Author
|
Just noticed it removed a lot of ones you already had, must be something up with the script I used to handle them. Will sort it and re-post. |
I have re-added all of the IDs that @gmcnew had already included. Some of them have the same numbers afterwards but I am assuming whichever ID is requested will now request the correct texture whether its data in the world is from 1.12 or 1.13. Forgive my ignorance but I have no experience coding for minecraft.
|
Hi Tollers, maybe you want to add it to the pull request where all the changes are? |
Author
|
I don't seem to have access to modify the world.py file there. I just editted it in gmcnew's branch. Is there anything else I can do? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have included all blocks and also all items. I presume including items isn't a problem as they shouldn't be requested and the length of the list shouldn't slow things down? If so, perhaps someone else can go through and remove them all.
Data was pulled from https://minecraft-ids.grahamedgecombe.com/ and put in to the right format with a string manipulation script I put together.