Skip to content

Comments

Bump dep and remove use of deprecated API#26

Merged
andydotxyz merged 3 commits intomainfrom
typesetting-new-api
Feb 24, 2026
Merged

Bump dep and remove use of deprecated API#26
andydotxyz merged 3 commits intomainfrom
typesetting-new-api

Conversation

@benoitkugler
Copy link
Contributor

@benoitkugler benoitkugler commented Feb 2, 2026

andydotxyz
andydotxyz approved these changes Feb 12, 2026
View reviewed changes
Copy link
Contributor

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andydotxyz
Copy link
Contributor

andydotxyz commented Feb 12, 2026 •
edited
Loading

I can't figure out the test failure.
According to my local tests it was caused by #24, but the Action test runner passed on the PR.

Either way this, or the previous, PR seem to have broken the rendering of bitmap fonts.

@benoitkugler
Copy link
Contributor Author

benoitkugler commented Feb 14, 2026

I have started digging into the issue, and I've found at least to issues : missing glyphs for cherry-10-r.otb and only the first letter of a run seems to be displayed.

This is quite a mess, and I don't really understand how it happened...

Anyway, I think I have a fix for the former point (the root cause is in typesetting/font). I will wait for go-text/typesetting#225 to be merged so that I can properly add cherry-10-r.otb to typesetting-utils test suite.

@benoitkugler benoitkugler marked this pull request as draft February 14, 2026 11:46
@benoitkugler benoitkugler mentioned this pull request Feb 23, 2026
Merged
@benoitkugler benoitkugler marked this pull request as ready for review February 23, 2026 16:28
@benoitkugler
Copy link
Contributor Author

benoitkugler commented Feb 23, 2026

Alright, bumping typesetting version fixed the two issues. (cc @andydotxyz )

andydotxyz
andydotxyz approved these changes Feb 24, 2026
View reviewed changes
Copy link
Contributor

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the fix

@andydotxyz andydotxyz merged commit 033b29c into main Feb 24, 2026
6 checks passed
@andydotxyz andydotxyz deleted the typesetting-new-api branch February 24, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@whereswaldon whereswaldon Awaiting requested review from whereswaldon whereswaldon is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@benoitkugler @andydotxyz