You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've tried and implemented @dominikh suggestion for a better language API.
This should be a gain for library users. The only concern I have is that we now have to use NewLanguage even on constant, obviously well formatted strings (think NewLanguage("en")).
Not sure if there is a better way. Perhaps adding a NewLanguageRaw(string) constructor which does nothing and would be inlined ?
I was wondering if typesetting would use the semi-standard libraries for languages and scripts.
Hum.. I'm not sure what would be the complications on the various generated tables. We would need a very compelling use case.
I also note that these types are mostly internal to the package : for most users, scripts are computed from the input text, and language are constructed via strings. For advanced users, converting to our types shouldn't be very difficult, should it ?
I felt that redefiniting types for languages and scripts was reinventing a wheel, but this is just out of curiosity.
I also note that these types are mostly internal to the package
This is used in the public API to determine glyphs correctly, right? (e.g. specifying ar and Arab was necessary to render Arabic texts correctly)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried and implemented @dominikh suggestion for a better language API.
This should be a gain for library users. The only concern I have is that we now have to use
NewLanguageeven on constant, obviously well formatted strings (thinkNewLanguage("en")).Not sure if there is a better way. Perhaps adding a
NewLanguageRaw(string)constructor which does nothing and would be inlined ?