Better calculate the transmit timeout for packets#292
Merged
sidcha merged 1 commit intogoToMain:masterfrom Mar 28, 2026
Merged
Conversation
sidcha
reviewed
Mar 27, 2026
sidcha
reviewed
Mar 27, 2026
Some packets(such as firmware upgrade packets) can be so large that they will cause a timeout on libosdp, especially at slower baud rates. Add in a way to calculate how long the packet transmission should take in order to have an acceptable timeout. See: goToMain#282
sidcha
added a commit
that referenced
this pull request
Apr 6, 2026
Commit 810d33d ("Better calculate the transmit timeout for packets") introduced a way to account for the trasmit time in when waiting for responsed by pre-computing an absolute time when the response is expected but then compared it with a duration returned by osdp_millis_since(). This patch fixes the issue by adjusting the comparison to the current tick value. Related-to: #292 Fixes: 810d33d Signed-off-by: Siddharth Chandrasekaran <sidcha.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some packets(such as firmware upgrade packets) can be so large that they will cause a timeout on libosdp, especially at slower baud rates. Add in a way to calculate how long the packet transmission should take in order to have an acceptable timeout.
see: #282