Closed
Conversation
3c816e4 to
826c50e
Compare
|
This would be extremely useful in a CI/CD context, where it would be nice to avoid rebuilding godot-cpp each time. |
|
As someone trying to get godot-cpp working this way through vcpkg and would love to also see a portfile.cmake for godot-cpp in the official registry, I'm highly interested in seeing this merged. |
Contributor
Author
|
I made some changes so we can now install the library to any directory (previously it worked directly on the build directory). cmake -S . -B build
cmake --build build -j12
cmake --install build --prefix $(realpath install)PS: after updating my branch I found this PR #1309. The two PRs are basically the same and the major difference is just naming. Usage of my PR Usage of #1309 |
0dba6da to
a9c0ee6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use cmake to build gdextension in linux. I used to make godot-cpp a submodule in my game project with
add_subdirectoryto create godot-cpp targets. It works fine but is a bit cumbersome.An alternative approach would be maintaining and building godot-cpp alone then telling my game project where the godot-cpp library is.
This PR makes cmake generate necessary files so that any other cmake-based projects can import godot-cpp like regular libraries. This makes it possible to share the compiled godot-cpp library among different projects.
Example:
and in my CMakeLists.txt I write: