Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLAs look good, thanks! |
31fe629 to
87f8993
Compare
| #endif | ||
|
|
||
| #ifdef __APPLE__ | ||
| ssize_t sendfile(int out_fd, int in_fd, off_t *offset, size_t count) |
There was a problem hiding this comment.
sendfile is available on BSD/MacOSX as well, e.g. https://developer.apple.com/library/archive/documentation/System/Conceptual/ManPages_iPhoneOS/man2/sendfile.2.html. It might have a slightly different signature than on Linux, but we shouldn't need to reimplement it.
|
Hi! Are you still interested in this? I've put together a few smaller changes in the |
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Inspired by pull request #76, thank you!
Adds macOS support remaining compatible with other platforms, i.e., intended to be merged with master branch. Works for all three modes: non-headless, headless with hardware acceleration and headless with software rendering. Build instructions found in
docs/build_macos.md. This addresses #7, #39 and possibly #22.