feat: Implement session deletion API (#105)#184
Open
furkankoykiran wants to merge 4 commits intogoogle-labs-code:mainfrom
Open
feat: Implement session deletion API (#105)#184furkankoykiran wants to merge 4 commits intogoogle-labs-code:mainfrom
furkankoykiran wants to merge 4 commits intogoogle-labs-code:mainfrom
Conversation
Enable DELETE HTTP method support for API requests to allow session deletion functionality.
Add permanent session deletion capability to SDK for complete lifecycle management.
Implement session deletion with API-first approach and write-through cache cleanup. Handles 404 gracefully to support idempotent deletion operations.
Add comprehensive test suite covering success case, 404 handling, and error propagation scenarios.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the
delete()method for theSessionClientclass to enable permanent session deletion from both the Jules API and local cache.Changes
DELETEmethod toApiRequestOptionstypedelete()method signature toSessionClientinterface with comprehensive JSDocdelete()inSessionClientImplwith:Test Results
delete()tests passImplementation Details
The implementation follows the existing patterns established by
archive()andunarchive()methods:this.request()sessionStorage.delete()methodResolves
Fixes #105
References