refactor: Remove placeholder loading text and caption usage hint from streaming components.#919
Open
nan-yu wants to merge 1 commit intogoogle:mainfrom
Open
refactor: Remove placeholder loading text and caption usage hint from streaming components.#919nan-yu wants to merge 1 commit intogoogle:mainfrom
nan-yu wants to merge 1 commit intogoogle:mainfrom
Conversation
The intent is to clean up the loading text in the intermediate states.
nan-yu
force-pushed
the
streaming-parser-cleanup
branch
from
eee6d8b to
9402f1d
Compare
| @@ -1232,8 +1232,7 @@ def traverse(obj, parent_key=None): | |||
| "id": placeholder_id, | |||
| "component": { | |||
| "Text": { | |||
Collaborator
There was a problem hiding this comment.
If it's empty, do we need to keep the text components at all? And if we need something to show, couldn't it be a Row with no children or something? And since they're all identical, they could be defined once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before
contact.lookup.streaming.demo.webm
restaurant.finder.sample.streaming.demo.webm
After
streaming.demo.contact.lookup.webm
streaming.demo.restaurant.finder.webm
Pre-launch Checklist
If you need help, consider asking for advice on the discussion board.