Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/com/google/adk/runner/Runner.java
Original file line number Diff line number Diff line change
Expand Up @@ -559,7 +559,7 @@ private Flowable<Event> runAgentWithFreshSession(
contextWithUpdatedSession
.agent()
.runAsync(contextWithUpdatedSession)
.flatMap(
.concatMap(
agentEvent ->
this.sessionService
.appendEvent(updatedSession, agentEvent)
Expand Down
42 changes: 42 additions & 0 deletions core/src/test/java/com/google/adk/runner/RunnerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@
import static com.google.common.truth.Truth.assertThat;
import static java.nio.charset.StandardCharsets.UTF_8;
import static java.util.Arrays.stream;
import static java.util.concurrent.TimeUnit.MILLISECONDS;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.CALLS_REAL_METHODS;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;

import com.google.adk.agents.BaseAgent;
import com.google.adk.agents.InvocationContext;
import com.google.adk.agents.LiveRequestQueue;
import com.google.adk.agents.LlmAgent;
Expand All @@ -43,6 +45,7 @@
import com.google.adk.flows.llmflows.Functions;
import com.google.adk.models.LlmResponse;
import com.google.adk.plugins.BasePlugin;
import com.google.adk.sessions.BaseSessionService;
import com.google.adk.sessions.Session;
import com.google.adk.sessions.SessionKey;
import com.google.adk.summarizer.EventsCompactionConfig;
Expand Down Expand Up @@ -851,6 +854,45 @@ public void beforeRunCallback_withStateDelta_seesMergedState() {
assertThat(sessionInCallback.state()).containsEntry("number", 123);
}

@Test
public void runAsync_ensureEventsAreAppendedInOrder() throws Exception {
Event event1 = TestUtils.createEvent("1");
Event event2 = TestUtils.createEvent("2");
BaseAgent mockAgent = TestUtils.createSubAgent("test agent", event1, event2);

BaseSessionService mockSessionService = mock(BaseSessionService.class);

when(mockSessionService.getSession(any(), any(), any(), any())).thenReturn(Maybe.just(session));
when(mockSessionService.appendEvent(any(), any()))
.thenAnswer(
invocation -> {
Event eventArg = invocation.getArgument(1);
Single<Event> result = Single.just(eventArg);
if (eventArg.id().equals("1")) {
// Artificially delay the first event to ensure it is appended first.
return result.delay(100, MILLISECONDS);
}
return result;
});

Runner mockRunner =
Runner.builder()
.agent(mockAgent)
.appName("test")
.sessionService(mockSessionService)
.build();

List<Event> results =
mockRunner
.runAsync("user", session.id(), createContent("user message"))
.toList()
.blockingGet();

assertThat(simplifyEvents(results))
.containsExactly("author: content for event 1", "author: content for event 2")
.inOrder();
}

private Content createContent(String text) {
return Content.builder().parts(Part.builder().text(text).build()).build();
}
Expand Down