fix(tdx): work around missing SIGNIFICANT_INDEX flag in KVM_TDX_CAPABILITIES#410
Merged
Lencerf merged 1 commit intogoogle:mainfrom Mar 1, 2026
Merged
fix(tdx): work around missing SIGNIFICANT_INDEX flag in KVM_TDX_CAPABILITIES#410Lencerf merged 1 commit intogoogle:mainfrom
Lencerf merged 1 commit intogoogle:mainfrom
Conversation
Pull Request Test Coverage Report for Build 22539829029Details
💛 - Coveralls |
…ILITIES The KvmCpuidEntry2 structures returned by KVM_TDX_CAPABILITIES currently omit the SIGNIFICANT_INDEX flag. This causes the CPUID index to be parsed as None instead of the actual index value, which breaks CPUID capability matching. Until this is fixed in the upstream kernel (see https://lore.kernel.org/all/20260223214336.722463-1-changyuanl@google.com/), work around the issue by explicitly retaining the index value from KvmCpuidEntry2 when parsing the capabilities. Fixes: ca9a64b ("feat(tdx): initialize TDX VMs with supported CPUID features") Signed-off-by: Changyuan Lyu <changyuanl@google.com>
bbd2b98 to
f5bf11a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KvmCpuidEntry2 structures returned by KVM_TDX_CAPABILITIES currently omit the SIGNIFICANT_INDEX flag. This causes the CPUID index to be parsed as None instead of the actual index value, which breaks CPUID capability matching.
Until this is fixed in the upstream kernel (see
https://lore.kernel.org/all/20260223214336.722463-1-changyuanl@google.com/), work around the issue by explicitly retaining the index value from KvmCpuidEntry2 when parsing the capabilities.
Fixes: ca9a64b ("feat(tdx): initialize TDX VMs with supported CPUID features")