Skip to content

changed extra_bootconfig_args to vector for multy vm support#2270

Merged
adelva1984 merged 1 commit intogoogle:mainfrom
adelva1984:multy_vm_extra_bootconfig_args_fix
Mar 17, 2026
Merged

changed extra_bootconfig_args to vector for multy vm support#2270
adelva1984 merged 1 commit intogoogle:mainfrom
adelva1984:multy_vm_extra_bootconfig_args_fix

Conversation

@adelva1984
Copy link
Collaborator

No description provided.

@adelva1984 adelva1984 requested a review from rmuthiah March 16, 2026 20:34
@adelva1984 adelva1984 enabled auto-merge March 16, 2026 20:34
@adelva1984 adelva1984 force-pushed the multy_vm_extra_bootconfig_args_fix branch from c66b442 to b6761fc Compare March 17, 2026 22:10
@adelva1984 adelva1984 added the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 17, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed the kokoro:force-run Trigger a presubmit build unconditionally. label Mar 17, 2026
@adelva1984 adelva1984 added this pull request to the merge queue Mar 17, 2026
Merged via the queue into google:main with commit 73094a2 Mar 17, 2026
26 checks passed
@Databean
Copy link
Member

extra_bootconfig_args is a free-text string, this now imposes the requirement that it cannot contain any commas. That may break some existing callers.

The strategy we used to deal with some other free-text flags for multi-instance vectorization was to instead add a new base64-encoded version of the flag, which could then be separated by commas.

In fact, we already have extra_bootconfig_args_base64_vec defined:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants