Update cisco.py to handle using raw protocol numbers in policy #170#224
Open
jrachele wants to merge 2 commits intogoogle:masterfrom
Open
Update cisco.py to handle using raw protocol numbers in policy #170#224jrachele wants to merge 2 commits intogoogle:masterfrom
jrachele wants to merge 2 commits intogoogle:masterfrom
Conversation
jrachele
commented
Oct 29, 2020
jrachele
commented
- Allowed passing along of raw numeric protocol in Cisco generator, using str.isnumeric()
- Added test to ensure that this feature works
- Minor cleanup of errant print statement leftover in other test [cisco_test.py:881]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.