Enable other programs to include headers using <>

[mapx]

This modification enable other projects to include this library headers with '#include <>'.

[mapx]

There was a reverted pull request #31 doing the same thing, and related discussion #25 .
So this PR might of little help. I wish there would be some improvement, in one kind or another.

[floitsch]

Yeah...
Not sure what to do there. This is not something I'm very familiar with, and @ulfjack last time seemed to think that not having "." is the correct thing to do.

[EdSchouten]

This patch currently seems necessary for me to be able to build a piece of software that uses this library. I can change the includes in my codebase to use "double-conversion/*", but the problem is that this library also contains includes to its own header files of the form <double-conversion/*>. Without this patch, those includes don't resolve.

[ulfjack]

In Bazel 0.22.0, the following code works for me:

WORKSPACE:

load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository")
git_repository(
  name = "double_conversion",
  remote = "https://github.com/google/double-conversion.git",
  branch = "master",
)

double/BUILD:

cc_test(
  name = "double",
  srcs = ["double.cc"],
  deps = ["@double_conversion//:double-conversion"],
)

double/double.cc:

#include <stdio.h>
#include "double-conversion/double-conversion.h"
int main(int argc, char** argv) {
  return 0;
}

As far as I can tell from the generated gcc command line, it looks like the current directory is already added to the quote includes. Can you point me at a case that doesn't work yet?

[floitsch]

@ulfjack : thanks for taking a look. I hope @EdSchouten or @mapx can find the time to respond to you.

Just as a side-note: just a few days ago I changed the code to use relative imports inside the project (except for the tests). Maybe that makes things simpler.

[EdSchouten]

Hi there!

Just as a side-note: just a few days ago I changed the code to use relative imports inside the project (except for the tests). Maybe that makes things simpler.

Yep. This fixes things for me. The problem was that the codebase itself contained #include <double-conversion/*.h> includes. Those are no longer present. Thanks!

[floitsch]

@belbel102711 : you approved this PR.
Does this mean that it is still necessary?

My interpretation was that @EdSchouten and @ulfjack both found that the PR is not necessary.

[hjmjohnson]

I think that the final conclusion is that this PR is not necessary. Given that it has been static for 5 years, perhaps it should be closed.