Skip to content

[Swift] Migrate to swift 6.0 and Implements support gRPC v2#8983

Open
mustiikhalil wants to merge 1 commit intogoogle:masterfrom
mustiikhalil:mmk/grpc-swift-2
Open

[Swift] Migrate to swift 6.0 and Implements support gRPC v2#8983
mustiikhalil wants to merge 1 commit intogoogle:masterfrom
mustiikhalil:mmk/grpc-swift-2

Conversation

@mustiikhalil
Copy link
Copy Markdown
Collaborator

@mustiikhalil mustiikhalil commented Mar 18, 2026

The following PR migrate the support for the swift library to swift 6.0, since that's the minimum version we can use for swift gRPC 2.0 which uses async/await under the hood. It would also enable us to migrate away from XCTests into swift testing in a future PR.

@github-actions github-actions bot added python c++ grpc codegen Involving generating code from schema swift labels Mar 18, 2026
@github-actions github-actions bot added the CI Continuous Integration label Mar 18, 2026
@mustiikhalil mustiikhalil changed the title [Swift] Implements code generation to support gRPC v2 [Swift] Migrate to swift 6.0 and Implements support gRPC v2 Mar 18, 2026
The following migrates to swift 6.0, and also
migrate to swift-grpc 2.0 that uses swift-nio
under the hood to provide nicer API and async await
@mustiikhalil mustiikhalil marked this pull request as ready for review March 25, 2026 21:06
@mustiikhalil mustiikhalil self-assigned this Mar 25, 2026
@mustiikhalil mustiikhalil requested a review from jtdavis777 March 25, 2026 21:08
@@ -31,349 +31,903 @@
namespace grpc_swift_generator {
namespace {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get your input on the generated code @jtdavis777

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, happy to take a look

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, nothing urgent.

@jtdavis777
Copy link
Copy Markdown
Collaborator

Is there much/any danger of causing compatibility breaks with this change? Will swift users be forced to update?

@mustiikhalil
Copy link
Copy Markdown
Collaborator Author

mustiikhalil commented Mar 25, 2026

Is there much/any danger of causing compatibility breaks with this change? Will swift users be forced to update?

Yes, users will be forced to update to swift 6.0. However that would only be for upcoming flatbuffers releases, and flatbuffers swift has been stable for a while now.

Usually I follow the swift-protobuf repository when it comes to supported swift versions. Currently the minimum there is swift 6.0 and it's been that for a while. Yesterday Apple released swift 6.3, and 6.4 should be released by the end of the year.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ CI Continuous Integration codegen Involving generating code from schema grpc python swift

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants