Add null check for type_vec in VerifyVector function#8996
Open
metsw24-max wants to merge 1 commit intogoogle:masterfrom
Open
Add null check for type_vec in VerifyVector function#8996metsw24-max wants to merge 1 commit intogoogle:masterfrom
metsw24-max wants to merge 1 commit intogoogle:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
VerifyVector, when handlingreflection::Unionvectors,type_veccould be null if the type vector field is absent in a malformed buffer. The existingv.VerifyVector(type_vec)call does not catch this — it returnstruefor null vectors by design. Execution then falls through totype_vec->size(), causing a null pointer dereference.Added an explicit null check before the size comparison to return
falseearly on malformed input, consistent with how the verifier handles other invalid states.