Implement sharing geometry with QR code#3585
Draft
andreia-ferreira wants to merge 5 commits intomasterfrom
Draft
Implement sharing geometry with QR code#3585andreia-ferreira wants to merge 5 commits intomasterfrom
andreia-ferreira wants to merge 5 commits intomasterfrom
Conversation
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces the capability to share geometry data using QR codes, which is enabled by a foundational architectural shift towards Kotlin Multiplatform. Key domain models and UI components have been extracted into dedicated multiplatform modules, laying the groundwork for future cross-platform development while modernizing the build system and cleaning up dependencies. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
# Conflicts: # app/src/main/java/org/groundplatform/android/ui/components/MapFloatingActionButton.kt # app/src/main/java/org/groundplatform/android/ui/components/RecenterButton.kt # app/src/main/java/org/groundplatform/android/ui/surveyselector/components/SurveyEmptyState.kt
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a significant refactoring to establish a multi-platform architecture by creating core/domain and core/ui modules. Shared code, including the Coordinates data class and theme files, has been moved to these new modules. A new GroundQrCode composable is also added to facilitate geometry sharing via QR codes. The changes are extensive, touching many files for import updates and build configuration, but they appear consistent and well-executed. My review focuses on the new component, where I've noted a couple of minor issues regarding the copyright year and the need for unit tests to align with the repository's style guide.
core/ui/src/commonMain/kotlin/org/groundplatform/ui/components/GroundQrCode.kt
Show resolved
Hide resolved
Comment on lines
+43
to
+49
| @Composable | ||
| fun GroundQrCode( | ||
| modifier: Modifier = Modifier, | ||
| content: String, | ||
| contentDescription: String, | ||
| centerLogoPainter: Painter?, | ||
| ) { |
Contributor
There was a problem hiding this comment.
This new composable introduces a new behavior. Please consider adding a UI test to verify that the QR code is generated and rendered correctly for the given content. This aligns with the repository's style guide which requires tests for new behaviors.
References
- Add or update unit tests for all new or changed behaviors. Remove unit tests for code which has been removed. (link)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #3575
During the implementation of this feature kmp shareable modules have been created :core:domain and :core:ui. The needed files will be refactored to those modules, when possible.
This PR will be split up to be easier to review -> still to be done