Skip to content

Add conditional question to ground app e2e test survey #2440

Merged
rfontanarosa merged 1 commit intogoogle:masterfrom
hassan-nsubuga:test/3481
Feb 27, 2026
Merged

Add conditional question to ground app e2e test survey #2440
rfontanarosa merged 1 commit intogoogle:masterfrom
hassan-nsubuga:test/3481

Conversation

@hassan-nsubuga
Copy link
Collaborator

Fixes #3481

The test survey doesn't have conditional questions/tasks. Add a conditional question to the test survey to aid tests in ground-android in order to prevent regressions

  • Edit survey to add a conditional question

@... PTAL?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @hassan-nsubuga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the accounts.json file by adding several new user entries, likely to expand the available test data for the application. However, the changes in the patch do not reflect the stated purpose in the PR title and description, which is to add a conditional question to an e2e test survey for the Ground Android app.

Highlights

  • Test Account Data: Multiple user accounts were added to data/test-android/auth_export/accounts.json, expanding the available test data.
  • Discrepancy with PR Description: The provided patch only shows changes to test account data, which does not align with the PR title and description's stated goal of adding a conditional question to an e2e test survey.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • data/test-android/auth_export/accounts.json
    • Added multiple user entries to the JSON array.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the test user accounts in data/test-android/auth_export/accounts.json. The main feedback is to improve the readability of this JSON file by formatting it, which will make it easier to review and maintain in the future. While the PR description mentions adding a conditional question to a survey, this change is not reflected in the provided diff.

@@ -1 +1 @@
{"kind":"identitytoolkit#DownloadAccountResponse","users":[]} No newline at end of file
{"kind":"identitytoolkit#DownloadAccountResponse","users":[{"localId":"7NN7t00BdE5wpZJoxOtGjfG6G4BZ","lastLoginAt":"1771319867922","createdAt":"1771319867922","lastRefreshAt":"2026-02-17T09:17:48.090Z"},{"localId":"FE1lWJepY2gbch5gFcKMZlSF2mn2","lastLoginAt":"1771321618015","createdAt":"1771321618015","lastRefreshAt":"2026-02-17T09:46:58.040Z"},{"localId":"KPZqKppnh95T4Zwsf6WZgYBai4X9","lastLoginAt":"1771320827348","createdAt":"1771320827348","lastRefreshAt":"2026-02-17T09:33:47.374Z"},{"localId":"U4b72L3Ft7tczQOzz54r9dTBDdTf","createdAt":"1770712429705","lastLoginAt":"1770712429705","validSince":"1771311089","emailVerified":false,"disabled":false},{"localId":"bDq60drNuKBgHZG14dKjTEXczIwF","lastLoginAt":"1771321312529","createdAt":"1771321312529","lastRefreshAt":"2026-02-17T09:41:52.679Z"},{"localId":"dfjY590WvRGzhjMJi5pUcM7uOWeT","lastLoginAt":"1771320140120","createdAt":"1771320140120","lastRefreshAt":"2026-02-17T09:22:20.137Z"},{"localId":"nJRZCo52PDx3LQhh9T9WLN5WW9Wp","lastLoginAt":"1771321747162","createdAt":"1771321747162","lastRefreshAt":"2026-02-17T09:49:07.171Z"},{"localId":"tlTeaeb1oCNICQGUSCkTLncyJKSa","lastLoginAt":"1771320270559","createdAt":"1771320270559","lastRefreshAt":"2026-02-17T09:24:30.580Z"},{"localId":"vmsuCdnG9zQ6Hvz9eyrUXdCz4od8","lastLoginAt":"1771321092896","createdAt":"1771321092896","lastRefreshAt":"2026-02-17T09:38:12.914Z"}]} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This single-line JSON is difficult to read and review. For better maintainability, please consider formatting it to be multi-line with standard indentation. This would make future changes much easier to manage and diff. While other similar files in the repository are also single-line, adopting a formatted style would be a good improvement for the project's codebase.

{
  "kind": "identitytoolkit#DownloadAccountResponse",
  "users": [
    {
      "localId": "7NN7t00BdE5wpZJoxOtGjfG6G4BZ",
      "lastLoginAt": "1771319867922",
      "createdAt": "1771319867922",
      "lastRefreshAt": "2026-02-17T09:17:48.090Z"
    },
    {
      "localId": "FE1lWJepY2gbch5gFcKMZlSF2mn2",
      "lastLoginAt": "1771321618015",
      "createdAt": "1771321618015",
      "lastRefreshAt": "2026-02-17T09:46:58.040Z"
    },
    {
      "localId": "KPZqKppnh95T4Zwsf6WZgYBai4X9",
      "lastLoginAt": "1771320827348",
      "createdAt": "1771320827348",
      "lastRefreshAt": "2026-02-17T09:33:47.374Z"
    },
    {
      "localId": "U4b72L3Ft7tczQOzz54r9dTBDdTf",
      "createdAt": "1770712429705",
      "lastLoginAt": "1770712429705",
      "validSince": "1771311089",
      "emailVerified": false,
      "disabled": false
    },
    {
      "localId": "bDq60drNuKBgHZG14dKjTEXczIwF",
      "lastLoginAt": "1771321312529",
      "createdAt": "1771321312529",
      "lastRefreshAt": "2026-02-17T09:41:52.679Z"
    },
    {
      "localId": "dfjY590WvRGzhjMJi5pUcM7uOWeT",
      "lastLoginAt": "1771320140120",
      "createdAt": "1771320140120",
      "lastRefreshAt": "2026-02-17T09:22:20.137Z"
    },
    {
      "localId": "nJRZCo52PDx3LQhh9T9WLN5WW9Wp",
      "lastLoginAt": "1771321747162",
      "createdAt": "1771321747162",
      "lastRefreshAt": "2026-02-17T09:49:07.171Z"
    },
    {
      "localId": "tlTeaeb1oCNICQGUSCkTLncyJKSa",
      "lastLoginAt": "1771320270559",
      "createdAt": "1771320270559",
      "lastRefreshAt": "2026-02-17T09:24:30.580Z"
    },
    {
      "localId": "vmsuCdnG9zQ6Hvz9eyrUXdCz4od8",
      "lastLoginAt": "1771321092896",
      "createdAt": "1771321092896",
      "lastRefreshAt": "2026-02-17T09:38:12.914Z"
    }
  ]
}

Copy link
Collaborator

@andreia-ferreira andreia-ferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested this new data with the updated test from google/ground-android#3579 and looks nice! 👍 good to merge this when that PR is also ready to merge

@hassan-nsubuga
Copy link
Collaborator Author

hassan-nsubuga commented Feb 26, 2026 via email

@rfontanarosa rfontanarosa merged commit 5c7978b into google:master Feb 27, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants