Add conditional question to ground app e2e test survey #2440
Add conditional question to ground app e2e test survey #2440rfontanarosa merged 1 commit intogoogle:masterfrom
Conversation
Summary of ChangesHello @hassan-nsubuga, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the test user accounts in data/test-android/auth_export/accounts.json. The main feedback is to improve the readability of this JSON file by formatting it, which will make it easier to review and maintain in the future. While the PR description mentions adding a conditional question to a survey, this change is not reflected in the provided diff.
| @@ -1 +1 @@ | |||
| {"kind":"identitytoolkit#DownloadAccountResponse","users":[]} No newline at end of file | |||
| {"kind":"identitytoolkit#DownloadAccountResponse","users":[{"localId":"7NN7t00BdE5wpZJoxOtGjfG6G4BZ","lastLoginAt":"1771319867922","createdAt":"1771319867922","lastRefreshAt":"2026-02-17T09:17:48.090Z"},{"localId":"FE1lWJepY2gbch5gFcKMZlSF2mn2","lastLoginAt":"1771321618015","createdAt":"1771321618015","lastRefreshAt":"2026-02-17T09:46:58.040Z"},{"localId":"KPZqKppnh95T4Zwsf6WZgYBai4X9","lastLoginAt":"1771320827348","createdAt":"1771320827348","lastRefreshAt":"2026-02-17T09:33:47.374Z"},{"localId":"U4b72L3Ft7tczQOzz54r9dTBDdTf","createdAt":"1770712429705","lastLoginAt":"1770712429705","validSince":"1771311089","emailVerified":false,"disabled":false},{"localId":"bDq60drNuKBgHZG14dKjTEXczIwF","lastLoginAt":"1771321312529","createdAt":"1771321312529","lastRefreshAt":"2026-02-17T09:41:52.679Z"},{"localId":"dfjY590WvRGzhjMJi5pUcM7uOWeT","lastLoginAt":"1771320140120","createdAt":"1771320140120","lastRefreshAt":"2026-02-17T09:22:20.137Z"},{"localId":"nJRZCo52PDx3LQhh9T9WLN5WW9Wp","lastLoginAt":"1771321747162","createdAt":"1771321747162","lastRefreshAt":"2026-02-17T09:49:07.171Z"},{"localId":"tlTeaeb1oCNICQGUSCkTLncyJKSa","lastLoginAt":"1771320270559","createdAt":"1771320270559","lastRefreshAt":"2026-02-17T09:24:30.580Z"},{"localId":"vmsuCdnG9zQ6Hvz9eyrUXdCz4od8","lastLoginAt":"1771321092896","createdAt":"1771321092896","lastRefreshAt":"2026-02-17T09:38:12.914Z"}]} No newline at end of file | |||
There was a problem hiding this comment.
This single-line JSON is difficult to read and review. For better maintainability, please consider formatting it to be multi-line with standard indentation. This would make future changes much easier to manage and diff. While other similar files in the repository are also single-line, adopting a formatted style would be a good improvement for the project's codebase.
{
"kind": "identitytoolkit#DownloadAccountResponse",
"users": [
{
"localId": "7NN7t00BdE5wpZJoxOtGjfG6G4BZ",
"lastLoginAt": "1771319867922",
"createdAt": "1771319867922",
"lastRefreshAt": "2026-02-17T09:17:48.090Z"
},
{
"localId": "FE1lWJepY2gbch5gFcKMZlSF2mn2",
"lastLoginAt": "1771321618015",
"createdAt": "1771321618015",
"lastRefreshAt": "2026-02-17T09:46:58.040Z"
},
{
"localId": "KPZqKppnh95T4Zwsf6WZgYBai4X9",
"lastLoginAt": "1771320827348",
"createdAt": "1771320827348",
"lastRefreshAt": "2026-02-17T09:33:47.374Z"
},
{
"localId": "U4b72L3Ft7tczQOzz54r9dTBDdTf",
"createdAt": "1770712429705",
"lastLoginAt": "1770712429705",
"validSince": "1771311089",
"emailVerified": false,
"disabled": false
},
{
"localId": "bDq60drNuKBgHZG14dKjTEXczIwF",
"lastLoginAt": "1771321312529",
"createdAt": "1771321312529",
"lastRefreshAt": "2026-02-17T09:41:52.679Z"
},
{
"localId": "dfjY590WvRGzhjMJi5pUcM7uOWeT",
"lastLoginAt": "1771320140120",
"createdAt": "1771320140120",
"lastRefreshAt": "2026-02-17T09:22:20.137Z"
},
{
"localId": "nJRZCo52PDx3LQhh9T9WLN5WW9Wp",
"lastLoginAt": "1771321747162",
"createdAt": "1771321747162",
"lastRefreshAt": "2026-02-17T09:49:07.171Z"
},
{
"localId": "tlTeaeb1oCNICQGUSCkTLncyJKSa",
"lastLoginAt": "1771320270559",
"createdAt": "1771320270559",
"lastRefreshAt": "2026-02-17T09:24:30.580Z"
},
{
"localId": "vmsuCdnG9zQ6Hvz9eyrUXdCz4od8",
"lastLoginAt": "1771321092896",
"createdAt": "1771321092896",
"lastRefreshAt": "2026-02-17T09:38:12.914Z"
}
]
}There was a problem hiding this comment.
tested this new data with the updated test from google/ground-android#3579 and looks nice! 👍 good to merge this when that PR is also ready to merge
|
[like] Nsubuga, Hassan (CSI) reacted to your message:
…________________________________
From: Andreia Ferreira ***@***.***>
Sent: Wednesday, February 25, 2026 2:30:53 PM
To: google/ground-platform ***@***.***>
Cc: Nsubuga, Hassan (CSI) ***@***.***>; Mention ***@***.***>
Subject: Re: [google/ground-platform] Add conditional question to ground app e2e test survey (PR #2440)
@andreia-ferreira approved this pull request.
tested this new data with the updated test from google/ground-android#3579<google/ground-android#3579> and looks good! 👍 let's merge this when that PR is also ready to merge
—
Reply to this email directly, view it on GitHub<#2440 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BNJR3J273GAWDDCBTXH72Y34NWWZ3AVCNFSM6AAAAACV7IXTCOVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTQNJUGYZTIMZWGY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Fixes #3481
The test survey doesn't have conditional questions/tasks. Add a conditional question to the test survey to aid tests in ground-android in order to prevent regressions
@... PTAL?