Skip to content

Handle missing cases in CollectAnnotatedSymbolsPsiVisitor#2862

Merged
jaschdoc merged 1 commit intomainfrom
fix-psi-visitor-crashes
Apr 14, 2026
Merged

Handle missing cases in CollectAnnotatedSymbolsPsiVisitor#2862
jaschdoc merged 1 commit intomainfrom
fix-psi-visitor-crashes

Conversation

@jaschdoc
Copy link
Copy Markdown
Collaborator

@jaschdoc jaschdoc commented Apr 9, 2026

I studied the structure of PsiAnnotation a bit further and found what is hopefully an exhaustive solution.

Related to #2816

@jaschdoc jaschdoc requested a review from ting-yuan as a code owner April 9, 2026 12:41
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch from fb528fe to a2887fa Compare April 9, 2026 12:42
@jaschdoc jaschdoc requested a review from bcorso April 9, 2026 12:43
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch 2 times, most recently from c43931d to ee70d77 Compare April 9, 2026 12:50
Copy link
Copy Markdown
Collaborator

@bcorso bcorso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ting-yuan ting-yuan requested a review from jsjeon April 9, 2026 21:40
ting-yuan
ting-yuan previously approved these changes Apr 9, 2026
@jaschdoc jaschdoc requested a review from troelsbjerre April 10, 2026 10:57
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch from ee70d77 to d22a2a4 Compare April 10, 2026 11:47
@jaschdoc jaschdoc requested a review from bcorso April 10, 2026 11:47
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch from d22a2a4 to 5fa573b Compare April 10, 2026 11:50
@jaschdoc jaschdoc requested a review from ting-yuan April 10, 2026 11:50
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch 3 times, most recently from 3035d09 to 701d49f Compare April 10, 2026 13:31
@jaschdoc jaschdoc force-pushed the fix-psi-visitor-crashes branch from 701d49f to 698a66f Compare April 13, 2026 09:43
@jaschdoc jaschdoc merged commit 4d4daf6 into main Apr 14, 2026
3 checks passed
@jaschdoc jaschdoc deleted the fix-psi-visitor-crashes branch April 14, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants