Skip to content

[transport] Move api to header and zero out variable #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esnguyen merged 1 commit into from
Mar 12, 2026
+23 −24
Merged

[transport] Move api to header and zero out variable #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 8 additions & 24 deletions transports/libhoth_mtd.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,21 +28,6 @@
#include "transports/libhoth_device.h"
#include "transports/libhoth_ec.h"

struct libhoth_mtd_device {
int fd;
unsigned int mailbox_address;
};

int libhoth_mtd_send_request(struct libhoth_device* dev, const void* request,
size_t request_size);

int libhoth_mtd_receive_response(struct libhoth_device* dev, void* response,
size_t max_response_size, size_t* actual_size,
int timeout_ms);

int libhoth_mtd_close(struct libhoth_device* dev);
int libhoth_mtd_reconnect(struct libhoth_device* dev);

static int mtd_read(int fd, unsigned int address, void* data, size_t data_len) {
if (fd < 0 || !data) {
return LIBHOTH_ERR_INVALID_PARAMETER;
Expand Down Expand Up @@ -139,17 +124,17 @@ static int mtd_open(const char* path, const char* name) {
return open(path, O_RDWR);
}

FILE* fp;
FILE* fp = NULL;
char* line = NULL;
size_t len = 0;
ssize_t read;
ssize_t read = 0;

fp = fopen("/proc/mtd", "r");
if (fp == NULL) {
return -1;
}

int status;
int status = LIBHOTH_ERR_FAIL;
int mtd_id = -1;
char mtd_size[20] = "";
char mtd_erasesize[20] = "";
Expand All @@ -163,9 +148,8 @@ static int mtd_open(const char* path, const char* name) {
}
// Strip '"' if any.
if (mtd_name[0] == '"') {
int i;
int name_len = strlen(mtd_name);
for (i = 0; i < name_len - 2; ++i) {
for (int i = 0; i < name_len - 2; ++i) {
mtd_name[i] = mtd_name[i + 1];
mtd_name[i + 1] = 0;
}
Expand All @@ -186,7 +170,7 @@ int libhoth_mtd_open(const struct libhoth_mtd_device_init_options* options,
return LIBHOTH_ERR_INVALID_PARAMETER;
}

int status;
int status = LIBHOTH_ERR_FAIL;
int fd = -1;
struct libhoth_device* dev = NULL;
struct libhoth_mtd_device* mtd_dev = NULL;
Expand Down Expand Up @@ -279,9 +263,9 @@ int libhoth_mtd_receive_response(struct libhoth_device* dev, void* response,
return LIBHOTH_ERR_INVALID_PARAMETER;
}

size_t total_bytes;
int status;
struct hoth_host_response host_response;
size_t total_bytes = 0;
int status = LIBHOTH_ERR_FAIL;
struct hoth_host_response host_response = {0};
struct libhoth_mtd_device* mtd_dev =
(struct libhoth_mtd_device*)dev->user_ctx;

Expand Down
15 changes: 15 additions & 0 deletions transports/libhoth_mtd.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,21 @@ struct libhoth_mtd_device_init_options {
unsigned int mailbox;
};

struct libhoth_mtd_device {
int fd;
unsigned int mailbox_address;
};

int libhoth_mtd_send_request(struct libhoth_device* dev, const void* request,
size_t request_size);

int libhoth_mtd_receive_response(struct libhoth_device* dev, void* response,
size_t max_response_size, size_t* actual_size,
int timeout_ms);

int libhoth_mtd_close(struct libhoth_device* dev);
int libhoth_mtd_reconnect(struct libhoth_device* dev);

// Note that the options struct only needs to to live for the duration of
// this function call. It can be destroyed once libhoth_mtd_open returns.
int libhoth_mtd_open(const struct libhoth_mtd_device_init_options* options,
Expand Down
Loading