Skip to content

Create v1 ocp.load_pytree backwards compatibility tests against static v0 and v1 checkpoints. #2948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Mar 26, 2026
Merged

Create v1 ocp.load_pytree backwards compatibility tests against static v0 and v1 checkpoints. #2948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions checkpoint/orbax/checkpoint/experimental/v1/_src/layout/orbax_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,6 @@ async def validate(self, path: Path):
except BaseException as e:
raise InvalidLayoutError(
f"Failed to interpret path {path} as a V1 Orbax checkpoint."
f" due to error encountered during validation: {e}"
) from e

async def validate_pytree(
Expand All @@ -337,8 +336,7 @@ async def validate_pytree(
await self._validate_pytree(path, checkpointable_name)
except BaseException as e:
raise InvalidLayoutError(
f"Failed to interpret path {path} as a V1 Orbax PyTree"
f" checkpoint. Encountered error during validation: {e}"
f"Failed to interpret path {path} as a V1 Orbax PyTree."
) from e

async def load_pytree(
Expand Down Expand Up @@ -568,8 +566,8 @@ async def _process_load_awaitables(
except BaseException as e: # pylint:disable=broad-exception-caught
raise registration.NoEntryError(
f"Failed to load checkpointable: {name} due to incompatible"
f" handler: {handlers[name]} found in registry:"
f" handler: {type(handlers[name])} found in registry:"
f" {self._handler_registry} for abstract checkpointable:"
f" {checkpointables_to_load[name]}.\nError details: {e}"
f" {checkpointables_to_load[name]}."
) from e
return loaded_checkpointables
4 changes: 1 addition & 3 deletions checkpoint/orbax/checkpoint/experimental/v1/_src/layout/orbax_v0_layout.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ async def validate(self, path: Path) -> None:
except BaseException as e:
raise InvalidLayoutError(
f"Failed to interpret path {path} as a V0 Orbax checkpoint."
f" due to error encountered during validation: {e}"
) from e

async def validate_pytree(
Expand All @@ -284,8 +283,7 @@ async def validate_pytree(
await self._validate_pytree(path, checkpointable_name)
except BaseException as e:
raise InvalidLayoutError(
f"Failed to interpret path {path} as a V0 Orbax PyTree"
f" checkpoint. Encountered error during validation: {e}"
f"Failed to interpret path {path} as a V0 Orbax PyTree."
) from e

async def load_pytree(
Expand Down
Loading
Loading