Skip to content

[ci] Roll pinned nightly toolchain#1401

Closed
google-pr-creation-bot wants to merge 1 commit intogoogle:mainfrom
google-pr-creation-bot:roll-pinned-nightly-toolchain-to-nightly-2024-06-06-for-main
Closed

[ci] Roll pinned nightly toolchain#1401
google-pr-creation-bot wants to merge 1 commit intogoogle:mainfrom
google-pr-creation-bot:roll-pinned-nightly-toolchain-to-nightly-2024-06-06-for-main

Conversation

@google-pr-creation-bot
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@jswrenn
Copy link
Collaborator

jswrenn commented Jun 7, 2024

The automatic roll is failing because of rust-lang/rust#123168, which adds size_of and align_of to the prelude. The automatic fixes applied by the roller (specifically, to un-qualify those calls) are invalid on our MSRV. This manifests as name resolution errors.

@joshlf
Copy link
Member

joshlf commented Jun 11, 2024

The automatic roll is failing because of rust-lang/rust#123168, which adds size_of and align_of to the prelude. The automatic fixes applied by the roller (specifically, to un-qualify those calls) are invalid on our MSRV. This manifests as name resolution errors.

Fixed in #1413.

@joshlf joshlf closed this Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants