Skip to content

fix: Use proper SPDX license identifier#2594

Merged
gkevinzheng merged 1 commit intogoogleapis:mainfrom
Shortfinga:main
Mar 24, 2026
Merged

fix: Use proper SPDX license identifier#2594
gkevinzheng merged 1 commit intogoogleapis:mainfrom
Shortfinga:main

Conversation

@Shortfinga
Copy link
Contributor

The official id for Apache 2.0 is Apache-2.0. This would make it way easier for automatic scanners.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2593 with option 1

The [official](https://spdx.org/licenses/Apache-2.0.html) id for Apache
2.0 is `Apache-2.0`. This would make it way easier for automatic
scanners.
@Shortfinga Shortfinga requested a review from a team as a code owner March 24, 2026 15:01
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 24, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the Apache 2.0 license identifier across multiple setup.py files and templates by adopting the official SPDX format, 'Apache-2.0'. This update ensures better compatibility with automated license scanning tools, which is crucial for improving the project's compliance and overall maintainability.

Highlights

  • Standardized License Identifier: The license string for Apache 2.0 has been updated to its official SPDX identifier, 'Apache-2.0', across various setup.py files and templates.
  • Improved Automatic Scanning: This change facilitates easier and more accurate automatic license scanning, enhancing compliance and maintainability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the license identifier to the proper SPDX format, Apache-2.0, across various setup.py files and generator templates. This change improves standardization and helps automated tools correctly identify the license. The changes are consistent and have been correctly applied to the generator templates, the project's own setup file, and the corresponding golden test files. I have reviewed the changes and found no issues.

@parthea parthea changed the title Use proper SPDX license identifier fix: Use proper SPDX license identifier Mar 24, 2026
Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Shortfinga!

@gkevinzheng gkevinzheng merged commit 84d01df into googleapis:main Mar 24, 2026
109 of 112 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use SPDX expressions

3 participants