Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.

chore(deps): update dependency requests to v2.33.0 [security]#2597

Closed
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/pypi-requests-vulnerability
Closed

chore(deps): update dependency requests to v2.33.0 [security]#2597
renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
renovate-bot:renovate/pypi-requests-vulnerability

Conversation

@renovate-bot
Copy link
Contributor

This PR contains the following updates:

Package Change Age Confidence
requests (changelog) ==2.32.5==2.33.0 age confidence

GitHub Vulnerability Alerts

CVE-2026-25645

Impact

The requests.utils.extract_zipped_paths() utility function uses a predictable filename when extracting files from zip archives into the system temporary directory. If the target file already exists, it is reused without validation. A local attacker with write access to the temp directory could pre-create a malicious file that would be loaded in place of the legitimate one.

Affected usages

Standard usage of the Requests library is not affected by this vulnerability. Only applications that call extract_zipped_paths() directly are impacted.

Remediation

Upgrade to at least Requests 2.33.0, where the library now extracts files to a non-deterministic location.

If developers are unable to upgrade, they can set TMPDIR in their environment to a directory with restricted write access.


Release Notes

psf/requests (requests)

v2.33.0

Compare Source

Announcements

  • 📣 Requests is adding inline types. If you have a typed code base that
    uses Requests, please take a look at #​7271. Give it a try, and report
    any gaps or feedback you may have in the issue. 📣

Security

  • CVE-2026-25645 requests.utils.extract_zipped_paths now extracts
    contents to a non-deterministic location to prevent malicious file
    replacement. This does not affect default usage of Requests, only
    applications calling the utility function directly.

Improvements

  • Migrated to a PEP 517 build system using setuptools. (#​7012)

Bugfixes

  • Fixed an issue where an empty netrc entry could cause
    malformed authentication to be applied to Requests on
    Python 3.11+. (#​7205)

Deprecations

  • Dropped support for Python 3.9 following its end of support. (#​7196)

Documentation

  • Various typo fixes and doc improvements.

Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate-bot renovate-bot requested a review from a team as a code owner March 26, 2026 16:41
@trusted-contributions-gcf trusted-contributions-gcf bot added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 26, 2026
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Mar 26, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the requests library to version 2.33.0 in requirements.txt. Feedback indicates that because requirements.txt is an autogenerated file, the version update should be performed by modifying requirements.in and regenerating the file rather than editing the generated output directly.

Comment on lines +1073 to +1075
requests==2.33.0 \
--hash=sha256:3324635456fa185245e24865e810cecec7b4caf933d7eb133dcde67d48cee69b \
--hash=sha256:c7ebc5e8b0f21837386ad0e1c8fe8b829fa5f544d8df3b2253bff14ef29d7652
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

While updating requests to v2.33.0 is correct for addressing the security vulnerability, modifying requirements.txt directly is not the right approach for this project. This file is autogenerated from requirements.in.

Any direct changes here will be lost the next time dependencies are compiled. To ensure the update is permanent, you should add requests>=2.33.0 to requirements.in and then regenerate requirements.txt by running the pip-compile command specified at the top of this file.

This ensures that the source of dependencies is updated, not just the generated output.

References
  1. Changes to generated code should be made by updating the generator template and then regenerating the output files, rather than directly modifying the generated files.
  2. For generated code, apply fixes to the generator templates rather than patching individual output files to ensure consistency across the codebase.

@ohmayr ohmayr closed this Mar 26, 2026
@forking-renovate
Copy link

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (==2.33.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@renovate-bot renovate-bot deleted the renovate/pypi-requests-vulnerability branch March 26, 2026 19:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

kokoro:force-run Add this label to force Kokoro to re-run the tests. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants