chore(deps): update dependency requests to v2.33.0 [security]#2597
chore(deps): update dependency requests to v2.33.0 [security]#2597renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the requests library to version 2.33.0 in requirements.txt. Feedback indicates that because requirements.txt is an autogenerated file, the version update should be performed by modifying requirements.in and regenerating the file rather than editing the generated output directly.
| requests==2.33.0 \ | ||
| --hash=sha256:3324635456fa185245e24865e810cecec7b4caf933d7eb133dcde67d48cee69b \ | ||
| --hash=sha256:c7ebc5e8b0f21837386ad0e1c8fe8b829fa5f544d8df3b2253bff14ef29d7652 |
There was a problem hiding this comment.
While updating requests to v2.33.0 is correct for addressing the security vulnerability, modifying requirements.txt directly is not the right approach for this project. This file is autogenerated from requirements.in.
Any direct changes here will be lost the next time dependencies are compiled. To ensure the update is permanent, you should add requests>=2.33.0 to requirements.in and then regenerate requirements.txt by running the pip-compile command specified at the top of this file.
This ensures that the source of dependencies is updated, not just the generated output.
References
- Changes to generated code should be made by updating the generator template and then regenerating the output files, rather than directly modifying the generated files.
- For generated code, apply fixes to the generator templates rather than patching individual output files to ensure consistency across the codebase.
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
==2.32.5→==2.33.0GitHub Vulnerability Alerts
CVE-2026-25645
Impact
The
requests.utils.extract_zipped_paths()utility function uses a predictable filename when extracting files from zip archives into the system temporary directory. If the target file already exists, it is reused without validation. A local attacker with write access to the temp directory could pre-create a malicious file that would be loaded in place of the legitimate one.Affected usages
Standard usage of the Requests library is not affected by this vulnerability. Only applications that call
extract_zipped_paths()directly are impacted.Remediation
Upgrade to at least Requests 2.33.0, where the library now extracts files to a non-deterministic location.
If developers are unable to upgrade, they can set
TMPDIRin their environment to a directory with restricted write access.Release Notes
psf/requests (requests)
v2.33.0Compare Source
Announcements
uses Requests, please take a look at #7271. Give it a try, and report
any gaps or feedback you may have in the issue. 📣
Security
requests.utils.extract_zipped_pathsnow extractscontents to a non-deterministic location to prevent malicious file
replacement. This does not affect default usage of Requests, only
applications calling the utility function directly.
Improvements
Bugfixes
malformed authentication to be applied to Requests on
Python 3.11+. (#7205)
Deprecations
Documentation
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.