chore: replace old python teams with cloud-sdk-python-team#1953
chore: replace old python teams with cloud-sdk-python-team#1953suztomo wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @suztomo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a maintenance update to the repository's CODEOWNERS file. The primary goal is to align the code ownership with current team structures by replacing an outdated Python team reference with a new, active team. This ensures that future changes to the Python client libraries are routed to the correct team for review and accountability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request performs a straightforward maintenance task of updating the .github/CODEOWNERS file. It replaces the old @googleapis/python-core-client-libraries team with @googleapis/cloud-sdk-python-team. The change is correct and has been applied consistently. I have added a suggestion to improve the file's conciseness and maintainability by grouping related paths.
| google/auth/_default.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/aws.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/credentials.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/downscoped.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/external_account.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/external_account_authorized_user.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/identity_pool.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/pluggable.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/sts.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| google/auth/impersonated_credentials.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test__default.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_aws.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_credentials.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_downscoped.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_external_account.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_external_account_authorized_user.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_identity_pool.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_pluggable.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_sts.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team | ||
| tests/test_impersonated_credentials.py @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team |
There was a problem hiding this comment.
For better maintainability, you can group the file paths under google/auth/ and tests/ since they share the same owners. This will make the CODEOWNERS file more concise and easier to manage in the future.
google/auth/ @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team
tests/ @googleapis/googleapis-auth @googleapis/aion-sdk @googleapis/cloud-sdk-python-team
Bug ID: b/479543683