feat(auditmanager): generate library#15937
Conversation
product-auto-label
bot
added
the
api: auditmanager
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request delivers the complete C++ client library for the Google Cloud Audit Manager API. It encompasses all generated client code, build system configurations, comprehensive documentation, and practical quickstart examples, enabling developers to seamlessly integrate and utilize the Audit Manager service within their C++ applications. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces the new GA library for the Audit Manager API. The changes are mostly generated code and configuration files to integrate the new library. I've found a couple of minor issues: one in the quickstart's Bazel workspace file regarding a hardcoded, outdated dependency version, and another in the default backoff policy configuration which uses a zero-second initial delay. My detailed comments are below.
| http_archive( | ||
| name = "google_cloud_cpp", | ||
| sha256 = "699955112a4c57ae9111fbadeff1698674a1762acd77daf36360e6dfc227dc93", | ||
| strip_prefix = "google-cloud-cpp-2.42.0", | ||
| url = "https://github.com/googleapis/google-cloud-cpp/archive/v2.42.0.tar.gz", | ||
| ) |
There was a problem hiding this comment.
The http_archive for google_cloud_cpp is pinned to v2.42.0, which is an outdated version. This can cause confusion and build issues for users following this quickstart. Please consider updating this to a more recent version or using placeholders that can be updated automatically during release.
| http_archive( | |
| name = "google_cloud_cpp", | |
| sha256 = "699955112a4c57ae9111fbadeff1698674a1762acd77daf36360e6dfc227dc93", | |
| strip_prefix = "google-cloud-cpp-2.42.0", | |
| url = "https://github.com/googleapis/google-cloud-cpp/archive/v2.42.0.tar.gz", | |
| ) | |
| http_archive( | |
| name = "google_cloud_cpp", | |
| sha256 = "UPDATE_WITH_LATEST_SHA256", | |
| strip_prefix = "google-cloud-cpp-UPDATE_WITH_LATEST_VERSION", | |
| url = "https://github.com/googleapis/google-cloud-cpp/archive/vUPDATE_WITH_LATEST_VERSION.tar.gz", | |
| ) |
| ExponentialBackoffPolicy( | ||
| std::chrono::seconds(0), std::chrono::seconds(1), | ||
| std::chrono::minutes(5), kBackoffScaling, kBackoffScaling) | ||
| .clone()); |
There was a problem hiding this comment.
The initial delay for the exponential backoff policy is set to 0 seconds. This means the first retry will be immediate, which is generally not desirable as it can overwhelm a temporarily struggling service. It's better to have a small initial delay. For consistency, you could use the same backoff settings as the polling policy, which uses a 1-second initial delay.
ExponentialBackoffPolicy(
std::chrono::seconds(1), std::chrono::minutes(5), kBackoffScaling)
.clone());
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15937 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 2460 2460
Lines 228901 228901
=======================================
+ Hits 212791 212805 +14
+ Misses 16110 16096 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This change is