chore(ci): update gcloud sdk version#15938
chore(ci): update gcloud sdk version#15938scotthart wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Summary of ChangesHello @scotthart, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request primarily focuses on maintenance updates for the continuous integration (CI) environment. It updates the Google Cloud SDK version used in the build process and modifies Bazel test commands to disable caching for integration test results, aiming to ensure tests run with the latest dependencies and produce consistent outcomes. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the gcloud SDK version used in CI and disables test caching for Storage and Spanner integration tests that use an emulator. The SDK update is a routine change. The change to disable test caching for some emulator tests but not others introduces an inconsistency. I have added a review comment suggesting to either apply the change consistently across all similar tests or to add a comment explaining the discrepancy, which would improve the script's maintainability.
| bazel "${verb}" "${args[@]}" --cache_test_results=no --test_tag_filters="integration-test,-ud-only" | ||
|
|
||
| io::log_h2 "Running Spanner integration tests (with emulator)" | ||
| "google/cloud/spanner/ci/${EMULATOR_SCRIPT}" \ | ||
| bazel "${verb}" "${args[@]}" --test_tag_filters="integration-test,-ud-only" | ||
| bazel "${verb}" "${args[@]}" --cache_test_results=no --test_tag_filters="integration-test,-ud-only" |
There was a problem hiding this comment.
The flag --cache_test_results=no has been added for Storage and Spanner tests, but not for the other emulator-based tests (Pub/Sub, Bigtable, REST). This introduces an inconsistency. For better maintainability, this flag should either be applied to all similar test runs in this function, or a comment should be added explaining why it's specific to Storage and Spanner.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #15938 +/- ##
=======================================
Coverage 92.96% 92.96%
=======================================
Files 2460 2460
Lines 228901 228901
=======================================
+ Hits 212791 212807 +16
+ Misses 16110 16094 -16 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1 participant
This change is