Conversation
Contributor
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
chingor13
changed the title
Member
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a mechanism to skip unit tests for specific modules during bulk builds by using a Maven profile bulkTests. The changes in .kokoro/build.sh activate this profile when a full build is performed, and the changes in the various pom.xml files define this profile to set <skipTests>true</skipTests>. The overall approach is sound. I have a suggestion to improve the robustness of the shell script by using an array for the optional Maven profile argument, which is a best practice in bash scripting to avoid potential issues with word splitting.
meltsufin
approved these changes
Mar 21, 2026
blakeli0
approved these changes
Mar 21, 2026
blakeli0
reviewed
Mar 21, 2026
meltsufin
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses a GitHub actions matrix and the dorny/paths-filter action (already in use) to conditionally run split unit tests for a select number of modules.
When running the bulk unit test suite, we enable use the
bulkTestsprofile. This profile is configured to skip the tests for the ones that have split tests.Also fixes the showcase-clirr check by installing necessary dependencies without running the enforcer check.
Fixes #12185