feat(bigquery): add url.template to span tracing#12181
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the observability of BigQuery operations by integrating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request enhances OpenTelemetry tracing for BigQuery RPC calls by including the URI template in the generated spans. The changes involve modifying HttpBigQueryRpc.java to pass the URI template to the createRpcTracingSpan method across various BigQuery operations (Dataset, Table, Routine, Job, TableData, Model, IAM policies). A new URL_TEMPLATE attribute key is defined in BigQueryTelemetryTracer.java, and HttpBigQueryRpcTest.java is updated to verify this attribute. The URL_TEMPLATE attribute key is removed from HttpTracingRequestInitializer.java, consolidating its definition. The review feedback suggests using the BigQueryTelemetryTracer.URL_TEMPLATE constant in the test file for improved maintainability and consistency.
...oogle-cloud-bigquery/src/test/java/com/google/cloud/bigquery/spi/v2/HttpBigQueryRpcTest.java
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This PR adds url.template to span tracing. It is added at client invocation as its not available in HttpRequest received by HttpTracingRequestInitializer.
Note this PR also adds this and previous PR attribute behind dev gate flag
example trace