ci: Add Maven fast profile to skip maven lifecycle plugins#12188
ci: Add Maven fast profile to skip maven lifecycle plugins#12188
fast profile to skip maven lifecycle plugins#12188Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Maven profile, Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
lqiu96
changed the title
fast profile to skip maven lifecycle plugins
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'fast' Maven profile in both google-cloud-pom-parent/pom.xml and sdk-platform-java/pom.xml. This profile is designed to skip various build plugins (e.g., checkstyle, Jacoco, SpotBugs) to accelerate build times. A review comment highlights that the 'fast' profile in sdk-platform-java/pom.xml might be redundant if it inherits from google-cloud-pom-parent, suggesting its removal to prevent duplication and enhance maintainability.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a new 'fast' Maven profile to centralize the skipping of various Maven plugins (e.g., Checkstyle, Enforcer, JaCoCo, Clirr) across the build system. This profile is then applied to various mvn commands in the Kokoro build scripts (.kokoro/build.sh, .kokoro/common.sh, .kokoro/dependencies.sh), allowing for the removal of individual -D*.skip=true flags. Feedback indicates that the 'fast' profile inadvertently disables the Maven Enforcer plugin and the dependency:analyze goal in .kokoro/dependencies.sh, which contradicts the script's intended purpose for those steps. Additionally, the 'fast' profile is duplicated in two different POM files, suggesting an opportunity for refactoring into a common parent POM for improved maintainability.
| <profile> | ||
| <id>fast</id> | ||
| <properties> | ||
| <checkstyle.skip>true</checkstyle.skip> | ||
| <enforcer.skip>true</enforcer.skip> | ||
| <jacoco.skip>true</jacoco.skip> | ||
| <clirr.skip>true</clirr.skip> | ||
| <spotbugs.skip>true</spotbugs.skip> | ||
| <pmd.skip>true</pmd.skip> | ||
| <animal.sniffer.skip>true</animal.sniffer.skip> | ||
| <fmt.skip>true</fmt.skip> | ||
| <flatten.skip>true</flatten.skip> | ||
| <mdep.analyze.skip>true</mdep.analyze.skip> | ||
| </properties> | ||
| </profile> |
There was a problem hiding this comment.
This fast profile is identical to the one defined in google-cloud-pom-parent/pom.xml. To improve maintainability and avoid code duplication, this profile should be defined in a common parent POM and inherited in both places. Please remove this duplicated profile and ensure it's inherited from a single source.
chingor13
left a comment
chingor13
left a comment
There was a problem hiding this comment.
How do you feel about naming the profiles based on their intent?
For example installOnly for when you want to do a module compile/install into your local maven repository. For this task, you would skip tests, clirr, enforcer, checkstyle etc.
Another separate profile for lint, native, integrationTests, etc. Most of these would be setting similar options (e.g. lint would also skip Tests and clirr)
Open to a different name. Intention was just to create one simple profile that could be run for whatever maven lifecycle and skip plugin executions. It wasn't aimed to be specific to a maven lifecycle (compile, test, or install) in particular.
Probably could be added if it's needed, though I think it may be easier to just do something like |
2 participants
Adding a maven profile that makes it easier to build modules faster locally. Added benefit is to make it easier to run faster builds in the CI.