chore(bq jdbc): change uber jar bundling rules

[logachev]

Add transformer for notice/license & remove them from exclusion list

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the uber JAR bundling process for the BigQuery JDBC driver. It introduces specific Maven Shade plugin transformers to correctly aggregate and include Apache license and notice information, while simultaneously removing the previous exclusions for these files. This ensures that the final bundled JAR properly contains all necessary legal metadata.

Highlights

• Maven Shade Plugin Configuration: Added ApacheLicenseResourceTransformer and ApacheNoticeResourceTransformer to ensure proper bundling of license and notice files within the uber JAR.
• Uber JAR Exclusions: Removed META-INF/LICENSE* and META-INF/NOTICE* from the excludes list in the maven-shade-plugin configuration, allowing these files to be processed by the new transformers.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the pom.xml to correctly handle license and notice files during the Maven shade process by adding ApacheLicenseResourceTransformer and ApacheNoticeResourceTransformer, and removing the general exclusion of META-INF/LICENSE* and META-INF/NOTICE*. However, a potential issue was identified where removing these wildcard exclusions without explicit transformers for all possible license file names (e.g., LICENSE.md) could lead to license information loss or compliance problems due to file overwrites in the shaded JAR. It is recommended to use AppendingTransformer for any non-standard license file names.

[gemini-code-assist]

Removing these wildcard excludes for LICENSE* and NOTICE* can lead to license information being lost. Files matching these wildcards but not named LICENSE or NOTICE (e.g., META-INF/LICENSE.md, META-INF/LICENSE-MIT.txt) will now be included in the uber JAR.

If multiple dependencies provide a file with the same path, one will overwrite the other, which can create license compliance issues.

To prevent this, consider using AppendingTransformer for other known license file names to merge their content. For example:

<transformer implementation="org.apache.maven.plugins.shade.resource.AppendingTransformer">
  <resource>META-INF/LICENSE.md</resource>
</transformer>

This would require identifying all such non-standard license files in your dependencies and adding a transformer for each.