fix(bigquery): allow timestamp format overrides in createQueryStream#7905
Open
rafal-hawrylak wants to merge 1 commit intogoogleapis:mainfrom
Open
fix(bigquery): allow timestamp format overrides in createQueryStream#7905rafal-hawrylak wants to merge 1 commit intogoogleapis:mainfrom
rafal-hawrylak wants to merge 1 commit intogoogleapis:mainfrom
Conversation
## Description This PR fixes a bug in createQueryStream where formatOptions were being stripped from the query object before reaching the internal request builder. This caused the library to always use the default ISO8601_STRING format, which is rejected by some BigQuery backends. By extracting these options in queryAsStream_ and passing them through to the request builder, users can now successfully opt-out of the new default behavior when necessary. ## Impact - createQueryStream now correctly handles formatOptions.timestampOutputFormat and formatOptions.useInt64Timestamp if provided in the options object. - Bypasses 'timestamp_output_format is not supported yet' errors in restricted environments. ## Testing - Updated unit tests in test/bigquery.ts to verify the 'Gatekeeper' fix. - Added a specific test case to verify that formatOptions are correctly passed through. - Verified that all existing BigQuery tests pass.
product-auto-label
bot
added
the
api: bigquery
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug in createQueryStream where formatOptions were being stripped from the query object before reaching the internal request builder. This caused the library to always use the default ISO8601_STRING format, which is rejected by some BigQuery backends.
By extracting these options in queryAsStream_ and passing them through to the request builder, users can now successfully opt-out of the new default behavior when necessary.
Impact
Testing