feat(BigQuery): Add support for Stateless Queries#8943
Draft
Hectorhammett wants to merge 5 commits intomainfrom
Draft
feat(BigQuery): Add support for Stateless Queries#8943Hectorhammett wants to merge 5 commits intomainfrom
Hectorhammett wants to merge 5 commits intomainfrom
Conversation
product-auto-label
bot
added
the
api: bigquery
Hectorhammett
force-pushed
the
statelessquery-prototype
branch
from
dd440a2 to
5ef86ea
Compare
bshaffer
reviewed
Feb 27, 2026
Comment on lines
+37
to
+38
| use function PHPUnit\Framework\isNull; | ||
|
|
Contributor
There was a problem hiding this comment.
I think this was accidental
Suggested change
| use function PHPUnit\Framework\isNull; |
| * | ||
| * @return array<mixed>|null | ||
| */ | ||
| public static function getQueryRequest(JobConfigurationInterface $jobConfiguration): array|null |
Contributor
There was a problem hiding this comment.
The fact that this returns an array when the object itself implements a toArray() method seems wrong. I would expect it to be something more like this:
if ($query->isStateless()) {
$stateless = StatelessJobConfiguration::fromQueryConfiguration($query);
$request = $stateless->toArray();
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.