-
Notifications
You must be signed in to change notification settings - Fork 1.6k
test: Add DBAPI 2.0 compliance test suite #16158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dbapi-driver-1
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Copyright 2026 Google LLC | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| # This file is intentionally left blank to mark this directory as a package. |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,39 @@ | ||||||
| # Copyright 2026 Google LLC | ||||||
| # | ||||||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
| # you may not use this file except in compliance with the License. | ||||||
| # You may obtain a copy of the License at | ||||||
| # | ||||||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||||||
| # | ||||||
| # Unless required by applicable law or agreed to in writing, software | ||||||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||||||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
| # See the License for the specific language governing permissions and | ||||||
| # limitations under the License. | ||||||
| """Helper functions for compliance tests.""" | ||||||
|
|
||||||
| import os | ||||||
|
|
||||||
| SPANNER_EMULATOR_HOST = os.environ.get("SPANNER_EMULATOR_HOST") | ||||||
|
|
||||||
| PROJECT_ID = "test-project" | ||||||
| INSTANCE_ID = "test-instance" | ||||||
| DATABASE_ID = "test-db" | ||||||
|
|
||||||
| EMULATOR_TEST_CONNECTION_STRING = ( | ||||||
| f"{SPANNER_EMULATOR_HOST}" | ||||||
| f"projects/{PROJECT_ID}" | ||||||
| f"/instances/{INSTANCE_ID}" | ||||||
| f"/databases/{DATABASE_ID}" | ||||||
| "?autoConfigEmulator=true" | ||||||
| ) | ||||||
|
|
||||||
|
|
||||||
| def setup_test_env() -> None: | ||||||
| print(f"Set SPANNER_EMULATOR_HOST to {os.environ['SPANNER_EMULATOR_HOST']}") | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Using
Suggested change
|
||||||
| print(f"Using Connection String: {get_test_connection_string()}") | ||||||
|
|
||||||
|
|
||||||
| def get_test_connection_string() -> str: | ||||||
| return EMULATOR_TEST_CONNECTION_STRING | ||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test process requires the
SPANNER_EMULATOR_HOSTandTEST_DIALECTenvironment variables, but they are not being passed tosession.run. An emptyenvdictionary is provided, which means the test environment will not have these crucial variables set, causing the tests to fail. You should pass these variables from the nox environment to the test execution environment.