feat: Add penalty to channel selection for fast server errors#2674
Open
neilw4 wants to merge 1 commit intogoogleapis:mainfrom
Open
feat: Add penalty to channel selection for fast server errors#2674neilw4 wants to merge 1 commit intogoogleapis:mainfrom
neilw4 wants to merge 1 commit intogoogleapis:mainfrom
Conversation
This change modifies the channel selection logic in BigtableChannelPool to add a penalty for channels that have recently experienced server errors that are likely to be transient. The new logic uses an "adjusted" outstanding RPC count, which includes a penalty for errors like UNKNOWN, UNIMPLEMENTED, INTERNAL, UNAVAILABLE, and DATA_LOSS. This will help to route traffic away from temporarily misbehaving servers and improve load balancing.
product-auto-label
bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change modifies the channel selection logic in BigtableChannelPool to add a penalty for channels that have recently experienced server errors that are likely to be transient and likely to be solved by picking a different server.