feat: implement deleteSourceObjects in Storage.compose#3528
Draft
nidhiii-27 wants to merge 2 commits intomainfrom
Draft
feat: implement deleteSourceObjects in Storage.compose#3528nidhiii-27 wants to merge 2 commits intomainfrom
nidhiii-27 wants to merge 2 commits intomainfrom
Conversation
Modified Storage.ComposeRequest to include the optional deleteSourceObjects parameter. Added DELETE_SOURCE_OBJECTS option to StorageRpc. Updated StorageImpl, GrpcStorageImpl, and HttpStorageRpc to propagate the new option to the backend. Added unit and integration tests to verify the implementation. Co-authored-by: nidhiii-27 <224584462+nidhiii-27@users.noreply.github.com>
product-auto-label
bot
added
size: m
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modified Storage.ComposeRequest to include the optional deleteSourceObjects parameter. Added DELETE_SOURCE_OBJECTS option to StorageRpc.
Updated StorageImpl, GrpcStorageImpl, and HttpStorageRpc to propagate the new option to the backend. Added unit and integration tests to verify the implementation.