Skip to content
This repository was archived by the owner on Mar 26, 2026. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
76ac50c
tests: fix TestMutateRow_Generic_DeadlineExceeded
feywind Sep 16, 2025
f18d7b2
tests: fix TestReadRow_Generic_DeadlineExceeded
feywind Sep 16, 2025
8927bda
Merge branch 'main' into conformance-fixes
feywind Oct 1, 2025
e657328
Merge branch 'main' into conformance-fixes
feywind Oct 30, 2025
5c758c2
chore: merge remote-tracking branch 'remotes/origin/main' into confor…
feywind Oct 31, 2025
ae08b1b
tests: wip on shifting test harness to TS
feywind Nov 11, 2025
305c9c1
wip: work in progress on updating testproxy
feywind Feb 11, 2026
7f9955b
tests: most of the conversion to typescript
feywind Feb 12, 2026
56a7aa8
tests: testproxy mostly working in TS now
feywind Feb 18, 2026
6518223
chore: merge remote-tracking branch 'remotes/origin/main' into confor…
feywind Feb 18, 2026
75b205c
chore: update copyrights
feywind Feb 18, 2026
83db592
build: actually compile testproxy protos
feywind Feb 18, 2026
5cd638f
chore: fix linting issues
feywind Feb 20, 2026
90434e5
tests: finish updating types for proxy unit tests
feywind Feb 20, 2026
90dc4b9
chore: more linting and types
feywind Feb 20, 2026
0d3c693
tests: revert some typing changes
feywind Feb 20, 2026
0a127d7
chore: still yet more joy of linting
feywind Feb 20, 2026
86c535a
tests: fix/bypass unit test issues caused by "tests: fix TestReadRow_…
feywind Feb 23, 2026
e4368cd
chore: merge remote-tracking branch 'remotes/origin/main' into confor…
feywind Feb 23, 2026
af4ba73
chore: lint
feywind Feb 23, 2026
585b8db
tests: update known failures and unsupported conformance tests
feywind Feb 23, 2026
1e4fc4d
chore: self-review from the branch
feywind Feb 23, 2026
6e3a82c
chore: remove testlog
feywind Feb 25, 2026
4b021ec
chore: revert "tests: fix TestMutateRow_Generic_DeadlineExceeded"
feywind Feb 25, 2026
7eec031
chore: revert "tests: fix TestReadRow_Generic_DeadlineExceeded"
feywind Feb 25, 2026
aade70e
chore: revert "tests: fix/bypass unit test issues caused by "tests: f…
feywind Feb 25, 2026
56a8545
chore: more cleanup of reverted stuff
feywind Feb 25, 2026
7bd157b
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 25, 2026
253e244
Merge branch 'conformance-fixes' of https://github.com/googleapis/nod…
gcf-owl-bot[bot] Feb 25, 2026
228fc57
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 25, 2026
114d268
Merge branch 'conformance-fixes' of https://github.com/googleapis/nod…
gcf-owl-bot[bot] Feb 25, 2026
82698df
tests: fix lost close() during close test
feywind Feb 25, 2026
ea20639
chore: merge remote-tracking branch 'remotes/origin/conformance-fixes…
feywind Feb 25, 2026
9cc501f
chore: restore protos owlbot broke
feywind Feb 25, 2026
ab592ea
chore: ignore log files in testproxy
feywind Feb 25, 2026
028fd49
build: separate testproxy protos
feywind Feb 25, 2026
f1ccf53
chore: move imports to point at new testproxy protos
feywind Feb 25, 2026
f44c799
build: include testproxy protos in build/
feywind Feb 25, 2026
2d783a3
tests: another broken usage of getBigtableClient
feywind Feb 26, 2026
0d1f246
tests: fix testproxy regressions around client close
feywind Feb 27, 2026
b967d5a
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] Feb 27, 2026
00bc246
tests: move CI tests to a less crowded zone
feywind Mar 2, 2026
c0ea5da
chore: restore custom endpoint port logic
feywind Mar 3, 2026
a68d39c
chore: fully restore the port logic
feywind Mar 3, 2026
80e451a
tests: move everything to central2 for system tests
feywind Mar 3, 2026
b74b137
tests: remap zones to try to resolve backup test issues
feywind Mar 4, 2026
6517fae
tests: update snapshots with correct regions
feywind Mar 6, 2026
220dc8d
tests: missed snapshot update
feywind Mar 6, 2026
e9da706
tests: remove added clientConfig and change how it's passed in
feywind Mar 6, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@
# https://help.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax


# Unless specified, the cloud-sdk-nodejs-team is the default owner for nodejs repositories.
* @googleapis/bigtable-team @googleapis/cloud-sdk-nodejs-team
# Unless specified, the jsteam is the default owner for nodejs repositories.
* @googleapis/bigtable-team @googleapis/cloud-sdk-nodejs-team @googleapis/jsteam
2 changes: 1 addition & 1 deletion .kokoro/mandatory-conformance.sh

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

20 changes: 10 additions & 10 deletions __snapshots__/cluster.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exports[
id: 'my-cluster',
options: {
nodes: 2,
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -29,7 +29,7 @@ exports[
reqOpts: {
cluster: {
name: 'projects/grape-spaceship-123/instances/i/clusters/my-cluster',
location: 'us-central1-b',
location: 'us-central2-d',
serveNodes: 2,
},
updateMask: {
Expand All @@ -49,7 +49,7 @@ exports[
options: {
nodes: 2,
storage: 'ssd',
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -59,7 +59,7 @@ exports[
reqOpts: {
cluster: {
name: 'projects/grape-spaceship-123/instances/i/clusters/my-cluster',
location: 'us-central1-b',
location: 'us-central2-d',
serveNodes: 2,
storage: 'ssd',
},
Expand All @@ -80,7 +80,7 @@ exports[
options: {
nodes: 2,
key: 'kms-key-name',
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -90,7 +90,7 @@ exports[
reqOpts: {
cluster: {
name: 'projects/grape-spaceship-123/instances/i/clusters/my-cluster',
location: 'us-central1-b',
location: 'us-central2-d',
serveNodes: 2,
key: 'kms-key-name',
},
Expand All @@ -113,7 +113,7 @@ exports[
encryption: {
kmsKeyName: 'kms-key-name',
},
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -123,7 +123,7 @@ exports[
reqOpts: {
cluster: {
name: 'projects/grape-spaceship-123/instances/i/clusters/my-cluster',
location: 'us-central1-b',
location: 'us-central2-d',
serveNodes: 2,
encryption: {
kmsKeyName: 'kms-key-name',
Expand All @@ -147,7 +147,7 @@ exports[
minServeNodes: 2,
maxServeNodes: 3,
cpuUtilizationPercent: 50,
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -157,7 +157,7 @@ exports[
reqOpts: {
cluster: {
name: 'projects/grape-spaceship-123/instances/i/clusters/my-cluster',
location: 'us-central1-b',
location: 'us-central2-d',
clusterConfig: {
clusterAutoscalingConfig: {
autoscalingTargets: {
Expand Down
20 changes: 10 additions & 10 deletions __snapshots__/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ exports[
options: {
clusters: {
nodes: 2,
location: 'us-central1-b',
location: 'us-central2-d',
id: 'my-cluster',
},
},
Expand All @@ -37,7 +37,7 @@ exports[
},
clusters: {
'my-cluster': {
location: 'projects/test-project/locations/us-central1-b',
location: 'projects/test-project/locations/us-central2-d',
serveNodes: 2,
defaultStorageType: 0,
},
Expand All @@ -56,7 +56,7 @@ exports[
clusters: {
nodes: 2,
storage: 'ssd',
location: 'us-central1-b',
location: 'us-central2-d',
id: 'my-cluster',
},
},
Expand All @@ -73,7 +73,7 @@ exports[
},
clusters: {
'my-cluster': {
location: 'projects/test-project/locations/us-central1-b',
location: 'projects/test-project/locations/us-central2-d',
serveNodes: 2,
defaultStorageType: 1,
},
Expand All @@ -92,7 +92,7 @@ exports[
clusters: {
nodes: 2,
key: 'kms-key-name',
location: 'us-central1-b',
location: 'us-central2-d',
id: 'my-cluster',
},
},
Expand All @@ -109,7 +109,7 @@ exports[
},
clusters: {
'my-cluster': {
location: 'projects/test-project/locations/us-central1-b',
location: 'projects/test-project/locations/us-central2-d',
serveNodes: 2,
defaultStorageType: 0,
encryptionConfig: {
Expand All @@ -133,7 +133,7 @@ exports[
encryption: {
kmsKeyName: 'kms-key-name',
},
location: 'us-central1-b',
location: 'us-central2-d',
id: 'my-cluster',
},
},
Expand All @@ -150,7 +150,7 @@ exports[
},
clusters: {
'my-cluster': {
location: 'projects/test-project/locations/us-central1-b',
location: 'projects/test-project/locations/us-central2-d',
serveNodes: 2,
defaultStorageType: 0,
encryptionConfig: {
Expand All @@ -173,7 +173,7 @@ exports[
minServeNodes: 2,
maxServeNodes: 3,
cpuUtilizationPercent: 50,
location: 'us-central1-b',
location: 'us-central2-d',
id: 'my-cluster',
},
},
Expand All @@ -190,7 +190,7 @@ exports[
},
clusters: {
'my-cluster': {
location: 'projects/test-project/locations/us-central1-b',
location: 'projects/test-project/locations/us-central2-d',
clusterConfig: {
clusterAutoscalingConfig: {
autoscalingTargets: {
Expand Down
20 changes: 10 additions & 10 deletions __snapshots__/instance.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ exports[
id: 'my-cluster',
options: {
nodes: 2,
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -30,7 +30,7 @@ exports[
parent: 'projects/my-project/instances/my-instance',
clusterId: 'my-cluster',
cluster: {
location: 'projects/my-project/locations/us-central1-b',
location: 'projects/my-project/locations/us-central2-d',
serveNodes: 2,
},
},
Expand All @@ -46,7 +46,7 @@ exports[
options: {
nodes: 2,
storage: 'ssd',
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -57,7 +57,7 @@ exports[
parent: 'projects/my-project/instances/my-instance',
clusterId: 'my-cluster',
cluster: {
location: 'projects/my-project/locations/us-central1-b',
location: 'projects/my-project/locations/us-central2-d',
serveNodes: 2,
defaultStorageType: 1,
},
Expand All @@ -74,7 +74,7 @@ exports[
options: {
nodes: 2,
key: 'kms-key-name',
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -85,7 +85,7 @@ exports[
parent: 'projects/my-project/instances/my-instance',
clusterId: 'my-cluster',
cluster: {
location: 'projects/my-project/locations/us-central1-b',
location: 'projects/my-project/locations/us-central2-d',
serveNodes: 2,
encryptionConfig: {
kmsKeyName: 'kms-key-name',
Expand All @@ -106,7 +106,7 @@ exports[
encryption: {
kmsKeyName: 'kms-key-name',
},
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -117,7 +117,7 @@ exports[
parent: 'projects/my-project/instances/my-instance',
clusterId: 'my-cluster',
cluster: {
location: 'projects/my-project/locations/us-central1-b',
location: 'projects/my-project/locations/us-central2-d',
serveNodes: 2,
encryptionConfig: {
kmsKeyName: 'kms-key-name',
Expand All @@ -137,7 +137,7 @@ exports[
minServeNodes: 2,
maxServeNodes: 3,
cpuUtilizationPercent: 50,
location: 'us-central1-b',
location: 'us-central2-d',
},
},
output: {
Expand All @@ -148,7 +148,7 @@ exports[
parent: 'projects/my-project/instances/my-instance',
clusterId: 'my-cluster',
cluster: {
location: 'projects/my-project/locations/us-central1-b',
location: 'projects/my-project/locations/us-central2-d',
clusterConfig: {
clusterAutoscalingConfig: {
autoscalingTargets: {
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@
"!**/*.map"
],
"scripts": {
"compile": "tsc -p . && cp -r proto* build/",
"compile-protos": "compileProtos src",
"compile": "tsc -p . && cp -r proto* build/ && cp -r testproxy/proto* build/testproxy/",
"compile-protos": "compileProtos src && sh testproxy/compile-protos.sh",
"predocs": "npm run compile",
"docs": "jsdoc -c .jsdoc.js",
"predocs-test": "npm run docs",
Expand All @@ -42,7 +42,7 @@
"pretest": "npm run compile",
"test": "c8 mocha build/test",
"test:snap": "SNAPSHOT_UPDATE=1 npm test",
"testproxy": "npm run compile && node testproxy/index.js",
"testproxy": "npm run compile && node build/testproxy/index.js",
"clean": "gts clean",
"precompile": "gts clean"
},
Expand Down
6 changes: 3 additions & 3 deletions src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -509,9 +509,9 @@ export class Bigtable {
options.apiEndpoint || process.env.BIGTABLE_EMULATOR_HOST;
this.customEndpoint = customEndpoint;

let customEndpointBaseUrl;
let customEndpointPort;
let sslCreds;
let customEndpointBaseUrl: string | undefined;
let customEndpointPort: number | undefined;
let sslCreds: gaxVendoredGrpc.ChannelCredentials | undefined;

if (customEndpoint) {
const customEndpointParts = customEndpoint.split(':');
Expand Down
2 changes: 1 addition & 1 deletion system-test/app-profile.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ describe('📦 App Profile', () => {
// Creates an instance with clusters
const instanceClusters = [
'us-east1-c',
'us-central1-b',
'us-central2-b',
'us-west1-b',
].map(location => {
return {
Expand Down
Loading
Loading