Skip to content

fix: GenAI SDK client(multimodal) - Fix "type mismatch" warnings in datasets module. #6571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
+18 −18
Open

fix: GenAI SDK client(multimodal) - Fix "type mismatch" warnings in datasets module. #6571

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 18 additions & 18 deletions vertexai/_genai/datasets.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1085,7 +1085,7 @@ def update_multimodal_dataset(
self,
*,
multimodal_dataset: types.MultimodalDatasetOrDict,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.UpdateMultimodalDatasetConfigOrDict] = None,
) -> types.MultimodalDataset:
"""Updates a multimodal dataset.

Expand All @@ -1109,9 +1109,9 @@ def update_multimodal_dataset(
_datasets_utils.validate_multimodal_dataset_bigquery_uri(multimodal_dataset)

if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.UpdateMultimodalDatasetConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.UpdateMultimodalDatasetConfig()

return self._update_multimodal_dataset(
config=config,
Expand All @@ -1125,7 +1125,7 @@ def get_multimodal_dataset(
self,
*,
name: str,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.VertexBaseConfigOrDict] = None,
) -> types.MultimodalDataset:
"""Gets a multimodal dataset.

Expand All @@ -1141,17 +1141,17 @@ def get_multimodal_dataset(
dataset.
"""
if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.VertexBaseConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.VertexBaseConfig()

return self._get_multimodal_dataset(config=config, name=name)

def delete_multimodal_dataset(
self,
*,
name: str,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.VertexBaseConfigOrDict] = None,
) -> types.MultimodalDatasetOperation:
"""Deletes a multimodal dataset.

Expand All @@ -1167,9 +1167,9 @@ def delete_multimodal_dataset(
multimodal dataset operation.
"""
if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.VertexBaseConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.VertexBaseConfig()

return self._delete_multimodal_dataset(config=config, name=name)

Expand Down Expand Up @@ -2309,7 +2309,7 @@ async def update_multimodal_dataset(
self,
*,
multimodal_dataset: types.MultimodalDatasetOrDict,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.UpdateMultimodalDatasetConfigOrDict] = None,
) -> types.MultimodalDataset:
"""Updates a multimodal dataset.

Expand All @@ -2329,9 +2329,9 @@ async def update_multimodal_dataset(
_datasets_utils.validate_multimodal_dataset_bigquery_uri(multimodal_dataset)

if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.UpdateMultimodalDatasetConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.UpdateMultimodalDatasetConfig()

return await self._update_multimodal_dataset(
config=config,
Expand All @@ -2345,7 +2345,7 @@ async def get_multimodal_dataset(
self,
*,
name: str,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.VertexBaseConfigOrDict] = None,
) -> types.MultimodalDataset:
"""Gets a multimodal dataset.

Expand All @@ -2361,17 +2361,17 @@ async def get_multimodal_dataset(
dataset.
"""
if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.VertexBaseConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.VertexBaseConfig()

return await self._get_multimodal_dataset(config=config, name=name)

async def delete_multimodal_dataset(
self,
*,
name: str,
config: Optional[types.CreateMultimodalDatasetConfigOrDict] = None,
config: Optional[types.VertexBaseConfigOrDict] = None,
) -> types.MultimodalDatasetOperation:
"""Deletes a multimodal dataset.

Expand All @@ -2387,9 +2387,9 @@ async def delete_multimodal_dataset(
multimodal dataset operation.
"""
if isinstance(config, dict):
config = types.CreateMultimodalDatasetConfig(**config)
config = types.VertexBaseConfig(**config)
elif not config:
config = types.CreateMultimodalDatasetConfig()
config = types.VertexBaseConfig()

return await self._delete_multimodal_dataset(config=config, name=name)

Expand Down
Loading